unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/19] gnu: Add r-lazyeval.
Date: Tue, 15 Sep 2015 16:42:34 +0200	[thread overview]
Message-ID: <87y4g77nhh.fsf@mdc-berlin.de> (raw)
In-Reply-To: <CAMfbzvC6NjyZE90mCcmXSwQSHDLbfNJQK7dLTukWZxFPNxH1Pw@mail.gmail.com>

Hi Vicente,

> Actually, nearly every synopsis and description in these patches are
> taken verbatim from CRAN.

That’s what I thought.  When I prepared my initial patches for R modules
to test the CRAN importer I found that I needed to edit both synopsis
and description for every package.  The quality of descriptions is
certainly better than for the average CPAN package, but it still
requires editing to fit in with the rest of the Guix packages.

> I'm not familiar enough with this package to amend the description
> provided by the author, so I replaced it with the one offered in the
> package's GitHub repository.

That’s okay.

> Upper-case characters corrected.
>
> New patch attached.

Thank you!

I think it’s okay, except maybe for the slightly overlong line
containing the hash.  Unless there are objections I’d like to push this
tonight (after dropping the hash to its own line).

~~ Ricardo


PS: I’m wrapping up a project at a bioinfo hackathon and your patches
were very helpful as I had trouble installing dplyr via R.  Your patches
made this much simpler, so thank you very much!

  reply	other threads:[~2015-09-15 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 16:45 [PATCH 02/19] gnu: Add r-lazyeval Vicente Vera
2015-09-14 10:43 ` Ricardo Wurmus
2015-09-14 19:34   ` Vicente Vera
2015-09-15 14:42     ` Ricardo Wurmus [this message]
2015-09-15 15:31       ` Vicente Vera
2015-09-15 17:33         ` Vicente Vera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4g77nhh.fsf@mdc-berlin.de \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=vicentemvp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).