* Re: 01/01: gnu: Add missing modules in games.scm. [not found] ` <20190429125700.9573820431@vcs0.savannah.gnu.org> @ 2019-04-30 8:41 ` Ludovic Courtès 2019-04-30 8:55 ` Nicolas Goaziou 0 siblings, 1 reply; 3+ messages in thread From: Ludovic Courtès @ 2019-04-30 8:41 UTC (permalink / raw) To: guix-devel, Nicolas Goaziou Hello, guix-commits@gnu.org skribis: > commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8 > Author: Nicolas Goaziou <mail@nicolasgoaziou.fr> > Date: Mon Apr 29 14:56:32 2019 +0200 > > gnu: Add missing modules in games.scm. The assist the reader ;-), I think it’s good to add a comment such as “This is a followup to commit XYZ.” > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -105,6 +105,8 @@ > #:use-module (gnu packages gstreamer) > #:use-module (gnu packages gtk) > #:use-module (gnu packages guile) > + #:use-module (gnu packages haskell) > + #:use-module (gnu packages haskell-crypto) A while back I moved Haskell games (and more) to haskell-apps.scm. The idea was that we could avoid loading all of Haskell when we’re not looking for anything related to Haskell. Would it make sense for you to move the Haskell games there? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: gnu: Add missing modules in games.scm. 2019-04-30 8:41 ` 01/01: gnu: Add missing modules in games.scm Ludovic Courtès @ 2019-04-30 8:55 ` Nicolas Goaziou 2019-04-30 14:25 ` Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: Nicolas Goaziou @ 2019-04-30 8:55 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel Hello, Ludovic Courtès <ludo@gnu.org> writes: >> commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8 >> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr> >> Date: Mon Apr 29 14:56:32 2019 +0200 >> >> gnu: Add missing modules in games.scm. > > The assist the reader ;-), I think it’s good to add a comment such as > “This is a followup to commit XYZ.” OK. >> --- a/gnu/packages/games.scm >> +++ b/gnu/packages/games.scm >> @@ -105,6 +105,8 @@ >> #:use-module (gnu packages gstreamer) >> #:use-module (gnu packages gtk) >> #:use-module (gnu packages guile) >> + #:use-module (gnu packages haskell) >> + #:use-module (gnu packages haskell-crypto) > > A while back I moved Haskell games (and more) to haskell-apps.scm. The > idea was that we could avoid loading all of Haskell when we’re not > looking for anything related to Haskell. > > Would it make sense for you to move the Haskell games there? This game is written in C++. The Haskell modules are required for the Pascal to C translator, which is used during the build, as explained in the comments. Since the Haskell code represents only a very tiny part of the code base, moving the whole package to haskell-apps.scm may be confusing. WDYT? Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: gnu: Add missing modules in games.scm. 2019-04-30 8:55 ` Nicolas Goaziou @ 2019-04-30 14:25 ` Ludovic Courtès 0 siblings, 0 replies; 3+ messages in thread From: Ludovic Courtès @ 2019-04-30 14:25 UTC (permalink / raw) To: Nicolas Goaziou; +Cc: guix-devel Hi, Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis: >>> --- a/gnu/packages/games.scm >>> +++ b/gnu/packages/games.scm >>> @@ -105,6 +105,8 @@ >>> #:use-module (gnu packages gstreamer) >>> #:use-module (gnu packages gtk) >>> #:use-module (gnu packages guile) >>> + #:use-module (gnu packages haskell) >>> + #:use-module (gnu packages haskell-crypto) >> >> A while back I moved Haskell games (and more) to haskell-apps.scm. The >> idea was that we could avoid loading all of Haskell when we’re not >> looking for anything related to Haskell. >> >> Would it make sense for you to move the Haskell games there? > > This game is written in C++. The Haskell modules are required for the > Pascal to C translator, which is used during the build, as explained in > the comments. Since the Haskell code represents only a very tiny part of > the code base, moving the whole package to haskell-apps.scm may be > confusing. > > WDYT? OK, it makes sense to keep it here in that case. I’m well aware that it’s next to impossible to keep things separate in the long term (for example, glibc could very well end up using Pandoc to build its doc), but that was a modest attempt at that. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-30 14:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20190429125659.26449.44426@vcs0.savannah.gnu.org> [not found] ` <20190429125700.9573820431@vcs0.savannah.gnu.org> 2019-04-30 8:41 ` 01/01: gnu: Add missing modules in games.scm Ludovic Courtès 2019-04-30 8:55 ` Nicolas Goaziou 2019-04-30 14:25 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).