unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: 01/01: gnu: Add missing modules in games.scm.
Date: Tue, 30 Apr 2019 10:41:13 +0200	[thread overview]
Message-ID: <87imuvnavq.fsf@gnu.org> (raw)
In-Reply-To: <20190429125700.9573820431@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 29 Apr 2019 08:57:00 -0400 (EDT)")

Hello,

guix-commits@gnu.org skribis:

> commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date:   Mon Apr 29 14:56:32 2019 +0200
>
>     gnu: Add missing modules in games.scm.

The assist the reader ;-), I think it’s good to add a comment such as
“This is a followup to commit XYZ.”

> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -105,6 +105,8 @@
>    #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages haskell)
> +  #:use-module (gnu packages haskell-crypto)

A while back I moved Haskell games (and more) to haskell-apps.scm.  The
idea was that we could avoid loading all of Haskell when we’re not
looking for anything related to Haskell.

Would it make sense for you to move the Haskell games there?

Thanks,
Ludo’.

       reply	other threads:[~2019-04-30  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190429125659.26449.44426@vcs0.savannah.gnu.org>
     [not found] ` <20190429125700.9573820431@vcs0.savannah.gnu.org>
2019-04-30  8:41   ` Ludovic Courtès [this message]
2019-04-30  8:55     ` 01/01: gnu: Add missing modules in games.scm Nicolas Goaziou
2019-04-30 14:25       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imuvnavq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).