From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: 01/01: gnu: Add missing modules in games.scm.
Date: Tue, 30 Apr 2019 10:55:22 +0200
Message-ID: <87y33r6fet.fsf@nicolasgoaziou.fr>
References: <20190429125659.26449.44426@vcs0.savannah.gnu.org>
	<20190429125700.9573820431@vcs0.savannah.gnu.org>
	<87imuvnavq.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:48666)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hLOXw-00029k-8x
	for guix-devel@gnu.org; Tue, 30 Apr 2019 04:55:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hLOXv-0000Dy-C6
	for guix-devel@gnu.org; Tue, 30 Apr 2019 04:55:28 -0400
In-Reply-To: <87imuvnavq.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
	=?utf-8?Q?s?= message of "Tue, 30 Apr 2019 10:41:13 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Hello,

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

>> commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8
>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> Date:   Mon Apr 29 14:56:32 2019 +0200
>>
>>     gnu: Add missing modules in games.scm.
>
> The assist the reader ;-), I think it=E2=80=99s good to add a comment suc=
h as
> =E2=80=9CThis is a followup to commit XYZ.=E2=80=9D

OK.

>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -105,6 +105,8 @@
>>    #:use-module (gnu packages gstreamer)
>>    #:use-module (gnu packages gtk)
>>    #:use-module (gnu packages guile)
>> +  #:use-module (gnu packages haskell)
>> +  #:use-module (gnu packages haskell-crypto)
>
> A while back I moved Haskell games (and more) to haskell-apps.scm.  The
> idea was that we could avoid loading all of Haskell when we=E2=80=99re not
> looking for anything related to Haskell.
>
> Would it make sense for you to move the Haskell games there?

This game is written in C++. The Haskell modules are required for the
Pascal to C translator, which is used during the build, as explained in
the comments. Since the Haskell code represents only a very tiny part of
the code base, moving the whole package to haskell-apps.scm may be
confusing.

WDYT?

Regards,

--=20
Nicolas Goaziou