Re: 01/01: gnu: Add missing modules in games.scm.

Re: 01/01: gnu: Add missing modules in games.scm.

[Ludovic Courtès]

Hello,

guix-commits@gnu.org skribis:

> commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date:   Mon Apr 29 14:56:32 2019 +0200
>
>     gnu: Add missing modules in games.scm.

The assist the reader ;-), I think it’s good to add a comment such as
“This is a followup to commit XYZ.”

> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -105,6 +105,8 @@
>    #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages haskell)
> +  #:use-module (gnu packages haskell-crypto)

A while back I moved Haskell games (and more) to haskell-apps.scm.  The
idea was that we could avoid loading all of Haskell when we’re not
looking for anything related to Haskell.

Would it make sense for you to move the Haskell games there?

Thanks,
Ludo’.

Re: 01/01: gnu: Add missing modules in games.scm.

[Nicolas Goaziou]

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

>> commit 1abe2e2a2916a230984a9a2be25eb0f6a78fd2f8
>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> Date:   Mon Apr 29 14:56:32 2019 +0200
>>
>>     gnu: Add missing modules in games.scm.
>
> The assist the reader ;-), I think it’s good to add a comment such as
> “This is a followup to commit XYZ.”

OK.

>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -105,6 +105,8 @@
>>    #:use-module (gnu packages gstreamer)
>>    #:use-module (gnu packages gtk)
>>    #:use-module (gnu packages guile)
>> +  #:use-module (gnu packages haskell)
>> +  #:use-module (gnu packages haskell-crypto)
>
> A while back I moved Haskell games (and more) to haskell-apps.scm.  The
> idea was that we could avoid loading all of Haskell when we’re not
> looking for anything related to Haskell.
>
> Would it make sense for you to move the Haskell games there?

This game is written in C++. The Haskell modules are required for the
Pascal to C translator, which is used during the build, as explained in
the comments. Since the Haskell code represents only a very tiny part of
the code base, moving the whole package to haskell-apps.scm may be
confusing.

WDYT?

Regards,

-- 
Nicolas Goaziou

Re: 01/01: gnu: Add missing modules in games.scm.

[Ludovic Courtès]

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>>> --- a/gnu/packages/games.scm
>>> +++ b/gnu/packages/games.scm
>>> @@ -105,6 +105,8 @@
>>>    #:use-module (gnu packages gstreamer)
>>>    #:use-module (gnu packages gtk)
>>>    #:use-module (gnu packages guile)
>>> +  #:use-module (gnu packages haskell)
>>> +  #:use-module (gnu packages haskell-crypto)
>>
>> A while back I moved Haskell games (and more) to haskell-apps.scm.  The
>> idea was that we could avoid loading all of Haskell when we’re not
>> looking for anything related to Haskell.
>>
>> Would it make sense for you to move the Haskell games there?
>
> This game is written in C++. The Haskell modules are required for the
> Pascal to C translator, which is used during the build, as explained in
> the comments. Since the Haskell code represents only a very tiny part of
> the code base, moving the whole package to haskell-apps.scm may be
> confusing.
>
> WDYT?

OK, it makes sense to keep it here in that case.

I’m well aware that it’s next to impossible to keep things separate in
the long term (for example, glibc could very well end up using Pandoc to
build its doc), but that was a modest attempt at that.

Thanks,
Ludo’.