* Format specification issue in the translations... @ 2023-05-22 23:57 Sebastian Rasmussen 2023-05-23 10:29 ` Julien Lepiller ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Sebastian Rasmussen @ 2023-05-22 23:57 UTC (permalink / raw) To: guix-devel Hi! I'm involved in the translation of Shepherd to Swedish, and poedit complains that the format specifications for the singular and plural forms of one of the strings are not the same: https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm#n1107 Later on in the source there is another string where the format specifications appear to be identical: https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm#n1221 If this is not a bug, please help me understand what can be done to make the translation tools not complain (even translationproject.org complains when I submit the .po-file). If this is indeed a bug in the source, do you mind fixing it? I'm not sure how your development process works, but if it helps I can fix it in a clone of the repo and post a link here..? / Sebastian ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Format specification issue in the translations... 2023-05-22 23:57 Format specification issue in the translations Sebastian Rasmussen @ 2023-05-23 10:29 ` Julien Lepiller 2023-05-23 10:44 ` pelzflorian (Florian Pelz) 2023-05-26 15:56 ` Ludovic Courtès 2 siblings, 0 replies; 6+ messages in thread From: Julien Lepiller @ 2023-05-23 10:29 UTC (permalink / raw) To: guix-devel, Sebastian Rasmussen Hi! I think it's indeed a bug in the Shepherd. Both forms should be identical for singular and plural. Especially, I think we should use ~{ ~a,~} in both cases since even when there's a single service, the argument is a list, so with only ~a, it wouldn't show properly. Le 23 mai 2023 01:57:05 GMT+02:00, Sebastian Rasmussen <sebras@gmail.com> a écrit : >Hi! > >I'm involved in the translation of Shepherd to Swedish, and >poedit complains that the format specifications for the singular >and plural forms of one of the strings are not the same: >https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm#n1107 > >Later on in the source there is another string where the format >specifications appear to be identical: >https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm#n1221 > >If this is not a bug, please help me understand what can be done >to make the translation tools not complain (even translationproject.org >complains when I submit the .po-file). > >If this is indeed a bug in the source, do you mind fixing it? >I'm not sure how your development process works, but if >it helps I can fix it in a clone of the repo and post a link here..? > > / Sebastian > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Format specification issue in the translations... 2023-05-22 23:57 Format specification issue in the translations Sebastian Rasmussen 2023-05-23 10:29 ` Julien Lepiller @ 2023-05-23 10:44 ` pelzflorian (Florian Pelz) 2023-05-23 11:01 ` Sebastian Rasmussen 2023-05-26 15:56 ` Ludovic Courtès 2 siblings, 1 reply; 6+ messages in thread From: pelzflorian (Florian Pelz) @ 2023-05-23 10:44 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: guix-devel Hi Sebastian, in German I have translated in this way and it got accepted. Although, I have not actually tested if it displays correctly. I assume Guile formatting is tolerant. #: modules/shepherd/service.scm:1087 #, scheme-format msgid "Cannot unregister service ~a, which is still running" msgid_plural "Cannot unregister services~{ ~a,~} which are still running" msgstr[0] "Der Dienst~{ ~a,~} bleibt registriert, weil er noch läuft" msgstr[1] "Die Dienste~{ ~a,~} bleiben registriert, weil sie noch laufen" Regards, Florian ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Format specification issue in the translations... 2023-05-23 10:44 ` pelzflorian (Florian Pelz) @ 2023-05-23 11:01 ` Sebastian Rasmussen 2023-05-24 7:03 ` [shepherd bug] " pelzflorian (Florian Pelz) 0 siblings, 1 reply; 6+ messages in thread From: Sebastian Rasmussen @ 2023-05-23 11:01 UTC (permalink / raw) To: guix-devel [-- Attachment #1: Type: text/plain, Size: 1026 bytes --] Hi Florian! > in German I have translated in this way and it got > accepted. Yes, my fellow Swedish translator pointed that out to me! :) I will contribute a similar translation in Swedish, but I also want the bug in the original code fixed. I have attached my attempt at a patch to this mail. Maybe someone can review it and help push it to git HEAD? > Although, I have not actually tested if it displays > correctly. I assume Guile formatting is tolerant. I have no means to easily test this either. / Sebastian On Tue, May 23, 2023 at 12:44 PM pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> wrote: > > > #: modules/shepherd/service.scm:1087 > #, scheme-format > msgid "Cannot unregister service ~a, which is still running" > msgid_plural "Cannot unregister services~{ ~a,~} which are still running" > msgstr[0] "Der Dienst~{ ~a,~} bleibt registriert, weil er noch läuft" > msgstr[1] "Die Dienste~{ ~a,~} bleiben registriert, weil sie noch laufen" > > Regards, > Florian [-- Attachment #2: 0001-service-Fix-localization-string-formatting.patch --] [-- Type: text/x-patch, Size: 1227 bytes --] From a7964514651c4f7852d930e6c0e38d06583fcd15 Mon Sep 17 00:00:00 2001 From: Sebastian Rasmussen <sebras@gmail.com> Date: Tue, 23 May 2023 12:52:36 +0200 Subject: [PATCH] service: Fix localization string formatting. * modules/shepherd/service.scm: Change the singular/plural formatting to be the same in order to avoid translation tool warnings. --- modules/shepherd/service.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm index e3ca910..c501a68 100644 --- a/modules/shepherd/service.scm +++ b/modules/shepherd/service.scm @@ -1104,8 +1104,8 @@ requests arriving on @var{channel}." (loop (unregister services))) (lst ; (local-output - (l10n "Cannot unregister service ~a, which is still running" - "Cannot unregister services~{ ~a,~} which are still running" + (l10n "Cannot unregister service ~{ ~a,~} which is still running" + "Cannot unregister services ~{ ~a,~} which are still running" (length lst)) (map service-canonical-name lst)) (loop registered)))) -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [shepherd bug] Re: Format specification issue in the translations... 2023-05-23 11:01 ` Sebastian Rasmussen @ 2023-05-24 7:03 ` pelzflorian (Florian Pelz) 0 siblings, 0 replies; 6+ messages in thread From: pelzflorian (Florian Pelz) @ 2023-05-24 7:03 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: guix-devel, ludo Sebastian Rasmussen <sebras@gmail.com> writes: > I will contribute a similar translation in Swedish, but I also > want the bug in the original code fixed. > > I have attached my attempt at a patch to this mail. > Maybe someone can review it and help push it to git HEAD? Cc to Ludo with changed subject. Regards, Florian ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Format specification issue in the translations... 2023-05-22 23:57 Format specification issue in the translations Sebastian Rasmussen 2023-05-23 10:29 ` Julien Lepiller 2023-05-23 10:44 ` pelzflorian (Florian Pelz) @ 2023-05-26 15:56 ` Ludovic Courtès 2 siblings, 0 replies; 6+ messages in thread From: Ludovic Courtès @ 2023-05-26 15:56 UTC (permalink / raw) To: Sebastian Rasmussen; +Cc: guix-devel Hi, Sebastian Rasmussen <sebras@gmail.com> skribis: > I'm involved in the translation of Shepherd to Swedish, and > poedit complains that the format specifications for the singular > and plural forms of one of the strings are not the same: > https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service.scm#n1107 This one is definitely a bug. I’ve now fixed it: https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=300fa7cf5c09b6022432e5450bcb12aadad41335 In the meantime you can do the same as Florian. Thanks for bringing it up! Ludo’. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-26 15:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-22 23:57 Format specification issue in the translations Sebastian Rasmussen 2023-05-23 10:29 ` Julien Lepiller 2023-05-23 10:44 ` pelzflorian (Florian Pelz) 2023-05-23 11:01 ` Sebastian Rasmussen 2023-05-24 7:03 ` [shepherd bug] " pelzflorian (Florian Pelz) 2023-05-26 15:56 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).