[PATCH 0/3] Add oslo.config.

[PATCH 0/3] Add oslo.config.

[Cyril Roelandt]

These three patches add oslo.config.

Cyril Roelandt (3):
  gnu: Add python-netaddr.
  gnu: Add python-stevedore.
  gnu: Add python-oslo.config.

 gnu/packages/openstack.scm | 80 ++++++++++++++++++++++++++++++++++++++++++++++
 gnu/packages/python.scm    | 28 ++++++++++++++++
 2 files changed, 108 insertions(+)

-- 
2.1.4

[PATCH 1/3] gnu: Add python-netaddr.

[Cyril Roelandt]

* gnu/packages/python.scm (python-netaddr, python2-netaddr): New variables.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index f9ad951..0231bce 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4739,3 +4739,31 @@ reading and writing MessagePack data.")
 
 (define-public python2-msgpack
   (package-with-python2 python-msgpack))
+
+(define-public python-netaddr
+  (package
+    (name "python-netaddr")
+    (version "0.7.18")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "https://pypi.python.org/packages/source/n/netaddr/netaddr-"
+               version
+               ".tar.gz"))
+        (sha256
+          (base32
+            "06dxjlbcicq7q3vqy8agq11ra01kvvd47j4mk6dmghjsyzyckxd1"))))
+    (build-system python-build-system)
+    (arguments `(#:tests? #f)) ;; No tests.
+    (inputs
+      `(("python-setuptools" ,python-setuptools)))
+    (home-page "https://github.com/drkjam/netaddr/")
+    (synopsis
+      "Pythonic manipulation of IPv4, IPv6, CIDR, EUI and MAC network addresses")
+    (description
+      "A Python library for representing and manipulating network addresses.")
+    (license bsd-3)))
+
+(define-public python2-netaddr
+  (package-with-python2 python-netaddr))
-- 
2.1.4

Re: [PATCH 1/3] gnu: Add python-netaddr.

[Mathieu Lirzin]

This is Mostly about formatting issues here

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/python.scm (python-netaddr, python2-netaddr): New variables.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f9ad951..0231bce 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4739,3 +4739,31 @@ reading and writing MessagePack data.")
>  
>  (define-public python2-msgpack
>    (package-with-python2 python-msgpack))
> +
> +(define-public python-netaddr
> +  (package
> +    (name "python-netaddr")
> +    (version "0.7.18")
> +    (source
> +      (origin

    (source
     (origin ...))
        
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://pypi.python.org/packages/source/n/netaddr/netaddr-"
> +               version
> +               ".tar.gz"))
                 
    (string-append
     "..." 
     ...)

> +        (sha256
> +          (base32
> +            "06dxjlbcicq7q3vqy8agq11ra01kvvd47j4mk6dmghjsyzyckxd1"))))

    (base32
     "....")

> +    (build-system python-build-system)
> +    (arguments `(#:tests? #f)) ;; No tests.
                                  
                                           ;no tests

> +    (inputs
> +      `(("python-setuptools" ,python-setuptools)))
> +    (home-page "https://github.com/drkjam/netaddr/")
> +    (synopsis
> +      "Pythonic manipulation of IPv4, IPv6, CIDR, EUI and MAC network addresses")

In order to keep synopsis small and the description longer that
synopsis, maybe you an move "IPv4, IPv6, CIDR, EUI and MAC" into the
description?

> +    (description
> +      "A Python library for representing and manipulating network addresses.")
> +    (license bsd-3)))
> +
> +(define-public python2-netaddr
> +  (package-with-python2 python-netaddr))

Otherwise LGTM.

--
Mathieu Lirzin

[PATCH 2/3] gnu: Add python-stevedore.

[Cyril Roelandt]

* gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables.
---
 gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 1641476..e5ba867 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -139,6 +139,49 @@ and sensible default behaviors into your setuptools run.")
 (define-public python2-pbr
   (package-with-python2 python-pbr))
 
+(define-public python-stevedore
+  (package
+    (name "python-stevedore")
+    (version "1.7.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "https://pypi.python.org/packages/source/s/stevedore/stevedore-"
+               version
+               ".tar.gz"))
+        (sha256
+          (base32
+            "149pjc0c3z6khjisn4yil3f94qjnzwafz093wc8rrzbw828qdkv8"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      `(("python-six" ,python-six)))
+    (inputs
+      `(("python-pbr" ,python-pbr)
+        ("python-setuptools" ,python-setuptools)
+        ;; Tests
+        ("python-docutils" ,python-docutils)
+        ("python-mock" ,python-mock)
+        ("python-oslotest" ,python-oslotest)
+        ("python-sphinx" ,python-sphinx)))
+    (home-page
+      "https://github.com/dreamhost/stevedore")
+    (synopsis
+      "Manage dynamic plugins for Python applications")
+    (description
+      "Python makes loading code dynamically easy, allowing you to configure
+and extend your application by discovering and loading extensions (“plugins”)
+at runtime.  Many applications implement their own library for doing this,
+using __import__ or importlib.  stevedore avoids creating yet another extension
+mechanism by building on top of setuptools entry points.  The code for managing
+entry points tends to be repetitive, though, so stevedore provides manager
+classes for implementing common patterns for using dynamically loaded
+extensions.")
+    (license asl2.0)))
+
+(define-public python2-stevedore
+  (package-with-python2 python-stevedore))
+
 ;; Packages from the Oslo library
 (define-public python-oslo.i18n
   (package
-- 
2.1.4

Re: [PATCH 2/3] gnu: Add python-stevedore.

[Mathieu Lirzin]

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables.
> ---
>  gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)

Same as previous review for formatting, otherwise LGTM.

--
Mathieu Lirzin

Re: [PATCH 2/3] gnu: Add python-stevedore.

[Cyril Roelandt]

On 09/12/2015 12:01 AM, Mathieu Lirzin wrote:
> Cyril Roelandt <tipecaml@gmail.com> writes:
> 
>> * gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables.
>> ---
>>  gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
> 
> Same as previous review for formatting, otherwise LGTM.


"guix import" does the formatting. Is it broken?


Cyril.

Re: [PATCH 2/3] gnu: Add python-stevedore.

[Thompson, David]

On Sun, Sep 13, 2015 at 1:05 PM, Cyril Roelandt <tipecaml@gmail.com> wrote:
> On 09/12/2015 12:01 AM, Mathieu Lirzin wrote:
>> Cyril Roelandt <tipecaml@gmail.com> writes:
>>
>>> * gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables.
>>> ---
>>>  gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 43 insertions(+)
>>
>> Same as previous review for formatting, otherwise LGTM.
>
> "guix import" does the formatting. Is it broken?

No, it's not broken, but it uses (ice-9 pretty-print) which is not
aware of all the indentation rules that we have in scheme-mode and our
.dir-locals.el file.

- Dave

Re: [PATCH 2/3] gnu: Add python-stevedore.

[Cyril Roelandt]

On 09/13/2015 10:11 PM, Thompson, David wrote:
> No, it's not broken, but it uses (ice-9 pretty-print) which is not
> aware of all the indentation rules that we have in scheme-mode and our
> .dir-locals.el file.

So, how can one use "guix import" and still produce a properly-indented
package definition?

Cyril.

Re: [PATCH 2/3] gnu: Add python-stevedore.

[Thompson, David]

On Sun, Sep 13, 2015 at 4:14 PM, Cyril Roelandt <tipecaml@gmail.com> wrote:
> On 09/13/2015 10:11 PM, Thompson, David wrote:
>> No, it's not broken, but it uses (ice-9 pretty-print) which is not
>> aware of all the indentation rules that we have in scheme-mode and our
>> .dir-locals.el file.
>
> So, how can one use "guix import" and still produce a properly-indented
> package definition?

You clean it up yourself.  The intent of 'guix import' is to reduce
boilerplate, not do produce perfect packages.

- Dave

[PATCH 3/3] gnu: Add python-oslo.config.

[Cyril Roelandt]

* gnu/packages/openstack.scm (python-oslo.config, python2-oslo.config): New variables.
---
 gnu/packages/openstack.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index e5ba867..dc30207 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -183,6 +183,43 @@ extensions.")
   (package-with-python2 python-stevedore))
 
 ;; Packages from the Oslo library
+(define-public python-oslo.config
+  (package
+    (name "python-oslo.config")
+    (version "2.4.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+               "https://pypi.python.org/packages/source/o/oslo.config/oslo.config-"
+               version
+               ".tar.gz"))
+        (sha256
+          (base32
+            "13r778jfb0fhna37c2pd1f2xipnsbd7zli7qhn96acrzymrwj5k1"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      `(("python-netaddr" ,python-netaddr)
+        ("python-six" ,python-six)
+        ("python-stevedore" ,python-stevedore)))
+    (inputs
+      `(("python-pbr" ,python-pbr)
+        ("python-setuptools" ,python-setuptools)
+        ;; Tests
+        ("python-oslo.i18n" ,python-oslo.i18n)
+        ("python-mock" ,python-mock)
+        ("python-oslotest" ,python-oslotest)
+        ("python-testscenarios" ,python-testscenarios)))
+    (home-page "https://launchpad.net/oslo")
+    (synopsis "Oslo Configuration API")
+    (description
+      "The Oslo configuration API supports parsing command line arguments and
+.ini style configuration files.")
+    (license asl2.0)))
+
+(define-public python2-oslo.config
+  (package-with-python2 python-oslo.config))
+
 (define-public python-oslo.i18n
   (package
     (name "python-oslo.i18n")
-- 
2.1.4

Re: [PATCH 3/3] gnu: Add python-oslo.config.

[Mathieu Lirzin]

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/openstack.scm (python-oslo.config, python2-oslo.config): New variables.
> ---
>  gnu/packages/openstack.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

LGTM (Like previous reviews for the formatting).

--
Mathieu Lirzin