From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 2/3] gnu: Add python-stevedore. Date: Sun, 13 Sep 2015 16:11:29 -0400 Message-ID: References: <1441665335-31855-1-git-send-email-tipecaml@gmail.com> <1441665335-31855-3-git-send-email-tipecaml@gmail.com> <87si6kk43m.fsf@openmailbox.org> <55F5ACC9.1070905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbDcb-0002qr-49 for guix-devel@gnu.org; Sun, 13 Sep 2015 16:11:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbDcX-0003QX-U0 for guix-devel@gnu.org; Sun, 13 Sep 2015 16:11:33 -0400 Received: from mail-yk0-f173.google.com ([209.85.160.173]:36690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbDcX-0003Ph-Q8 for guix-devel@gnu.org; Sun, 13 Sep 2015 16:11:29 -0400 Received: by ykdt18 with SMTP id t18so115488390ykd.3 for ; Sun, 13 Sep 2015 13:11:29 -0700 (PDT) In-Reply-To: <55F5ACC9.1070905@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel On Sun, Sep 13, 2015 at 1:05 PM, Cyril Roelandt wrote: > On 09/12/2015 12:01 AM, Mathieu Lirzin wrote: >> Cyril Roelandt writes: >> >>> * gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables. >>> --- >>> gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >> >> Same as previous review for formatting, otherwise LGTM. > > "guix import" does the formatting. Is it broken? No, it's not broken, but it uses (ice-9 pretty-print) which is not aware of all the indentation rules that we have in scheme-mode and our .dir-locals.el file. - Dave