From: "Thompson, David" <dthompson2@worcester.edu>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/3] gnu: Add python-stevedore.
Date: Sun, 13 Sep 2015 16:11:29 -0400 [thread overview]
Message-ID: <CAJ=RwfbvFiG=yZpRH_WGaK8tzSb-vZvgGME4LmOti2wPpZX7bA@mail.gmail.com> (raw)
In-Reply-To: <55F5ACC9.1070905@gmail.com>
On Sun, Sep 13, 2015 at 1:05 PM, Cyril Roelandt <tipecaml@gmail.com> wrote:
> On 09/12/2015 12:01 AM, Mathieu Lirzin wrote:
>> Cyril Roelandt <tipecaml@gmail.com> writes:
>>
>>> * gnu/packages/openstack.scm (python-stevedore, python2-stevedore): New variables.
>>> ---
>>> gnu/packages/openstack.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 43 insertions(+)
>>
>> Same as previous review for formatting, otherwise LGTM.
>
> "guix import" does the formatting. Is it broken?
No, it's not broken, but it uses (ice-9 pretty-print) which is not
aware of all the indentation rules that we have in scheme-mode and our
.dir-locals.el file.
- Dave
next prev parent reply other threads:[~2015-09-13 20:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 22:35 [PATCH 0/3] Add oslo.config Cyril Roelandt
2015-09-07 22:35 ` [PATCH 1/3] gnu: Add python-netaddr Cyril Roelandt
2015-09-11 21:57 ` Mathieu Lirzin
2015-09-07 22:35 ` [PATCH 2/3] gnu: Add python-stevedore Cyril Roelandt
2015-09-11 22:01 ` Mathieu Lirzin
2015-09-13 17:05 ` Cyril Roelandt
2015-09-13 20:11 ` Thompson, David [this message]
2015-09-13 20:14 ` Cyril Roelandt
2015-09-13 20:16 ` Thompson, David
2015-09-07 22:35 ` [PATCH 3/3] gnu: Add python-oslo.config Cyril Roelandt
2015-09-11 22:11 ` Mathieu Lirzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbvFiG=yZpRH_WGaK8tzSb-vZvgGME4LmOti2wPpZX7bA@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).