From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH 1/3] gnu: Add python-netaddr.
Date: Fri, 11 Sep 2015 23:57:15 +0200
Message-ID: <87wpvwk4as.fsf@openmailbox.org>
References: <1441665335-31855-1-git-send-email-tipecaml@gmail.com>
	<1441665335-31855-2-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZaWK4-0005Sr-K1
	for guix-devel@gnu.org; Fri, 11 Sep 2015 17:57:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZaWK1-0004dT-ET
	for guix-devel@gnu.org; Fri, 11 Sep 2015 17:57:32 -0400
Received: from mail2.openmailbox.org ([62.4.1.33]:38098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZaWK1-0004cy-6y
	for guix-devel@gnu.org; Fri, 11 Sep 2015 17:57:29 -0400
In-Reply-To: <1441665335-31855-2-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Tue, 8 Sep 2015 00:35:33 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

This is Mostly about formatting issues here

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/python.scm (python-netaddr, python2-netaddr): New variables.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f9ad951..0231bce 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4739,3 +4739,31 @@ reading and writing MessagePack data.")
>  
>  (define-public python2-msgpack
>    (package-with-python2 python-msgpack))
> +
> +(define-public python-netaddr
> +  (package
> +    (name "python-netaddr")
> +    (version "0.7.18")
> +    (source
> +      (origin

    (source
     (origin ...))
        
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://pypi.python.org/packages/source/n/netaddr/netaddr-"
> +               version
> +               ".tar.gz"))
                 
    (string-append
     "..." 
     ...)

> +        (sha256
> +          (base32
> +            "06dxjlbcicq7q3vqy8agq11ra01kvvd47j4mk6dmghjsyzyckxd1"))))

    (base32
     "....")

> +    (build-system python-build-system)
> +    (arguments `(#:tests? #f)) ;; No tests.
                                  
                                           ;no tests

> +    (inputs
> +      `(("python-setuptools" ,python-setuptools)))
> +    (home-page "https://github.com/drkjam/netaddr/")
> +    (synopsis
> +      "Pythonic manipulation of IPv4, IPv6, CIDR, EUI and MAC network addresses")

In order to keep synopsis small and the description longer that
synopsis, maybe you an move "IPv4, IPv6, CIDR, EUI and MAC" into the
description?

> +    (description
> +      "A Python library for representing and manipulating network addresses.")
> +    (license bsd-3)))
> +
> +(define-public python2-netaddr
> +  (package-with-python2 python-netaddr))

Otherwise LGTM.

--
Mathieu Lirzin