From: Maxime Devos <maximedevos@telenet.be>
To: Roman Scherer <roman.scherer@burningswell.com>, guix-patches@gnu.org
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs
Date: Sat, 19 Mar 2022 21:10:52 +0100 [thread overview]
Message-ID: <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> (raw)
In-Reply-To: <87fsnevtxi.fsf@burningswell.com>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
Roman Scherer schreef op za 19-03-2022 om 16:29 [+0100]:
> the emacs-lsp-treemacs package does not bundle it's icons. This patch
> fixes the issue by copying the icons to `share/emacs-lsp-
> treemacs/icons` and patching the paths in `lsp-treemacs-themes.el`.
That might technically solves matter, though instead of copying, why
not just change
(string-append "\"" out "/share/" ,name "/icons/" name "\"")
to the location of the icons? Unless you meant something else with
bundling here ...
Also, what do you mean with bundling exactly? AFAICT, the icons _are_
bundled, in the directory 'icons', and so far they have not yet been
unbundled in Guix -- the problem is that they are not installed (yet)
-- in that case, the patch seems reasonable to me.
Additionally, there may be some licensing problems. The icons
apparently come from ‘eclipse’, ‘idea’ and ‘netbeans’. I don't
actually know which license these have, but:
* idea is propietary, so probably its icons are as well
* Eclipse is ASL, which probably has some kind of requirement
that you need to preserve license and copyright information,
which seems to be completely ignored here.
* the relevant licenses don't appear to be entioned in the
'licenses' field.
As such, if these problems are not resolved, I think it will be
necessary to remove emacs-lsp-treemacs.
It seems like emacs-company-box
(https://github.com/sebastiencs/company-box/tree/master/images)
has the same problem as well.
Also seem upstream <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-19 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 23:31 bug#50329: Missing icon folder in emacs-lsp-treemacs package Cayetano Santos
2022-03-19 14:33 ` bug#50329: [PATCH v2 1/2] gnu: emacs-lsp-treemacs: Remove unclearly licensed icons r0man
2023-01-22 9:09 ` Liliana Marie Prikler
2022-03-19 15:29 ` bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Roman Scherer
2022-03-19 20:10 ` Maxime Devos [this message]
2022-03-20 8:59 ` Roman Scherer
2022-03-20 9:41 ` Maxime Devos
2022-03-20 10:35 ` Roman Scherer
2022-03-20 11:15 ` Liliana Marie Prikler
2022-03-20 11:21 ` Roman Scherer
2022-03-20 13:10 ` Liliana Marie Prikler
2022-03-20 13:58 ` Roman Scherer
2022-03-20 15:46 ` Liliana Marie Prikler
2022-03-20 17:58 ` Roman Scherer
2022-03-20 13:29 ` bug#50329: [PATCH v2 2/2] gnu: emacs-company-box: Remove unclearly licensed icons from source Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guix-patches@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=roman.scherer@burningswell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).