unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Roman Scherer <roman.scherer@burningswell.com>,
	Maxime Devos <maximedevos@telenet.be>
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>, 50329@debbugs.gnu.org
Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs
Date: Sun, 20 Mar 2022 12:15:48 +0100	[thread overview]
Message-ID: <c02a771f87791518ea8cfedd8ec83da343a8e5cb.camel@gmail.com> (raw)
In-Reply-To: <87sfrc7vqw.fsf@burningswell.com>

Hi Roman, hi Maxime,

Am Sonntag, dem 20.03.2022 um 11:35 +0100 schrieb Roman Scherer:
> Hi Maxime,
> 
> ok, I see. Thanks for the explanation. I attached a patch that
> removes the icons from the source as per your suggestion.
> 
> What do you think about this one?
> 
> Thanks, Roman.
The logic behind your patch LGTM, but it lacks an explanatory comment.
Don't worry about resending the patch, though -- I already added the
comment locally and am currently looking to also apply this to emacs-
company-box.  If either of you could check whether those icons are
referred to by name in emacs-lsp-treemacs while I'm working on company-
box, that'd be appreciated.

Cheers




  reply	other threads:[~2022-03-20 11:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 23:31 bug#50329: Missing icon folder in emacs-lsp-treemacs package Cayetano Santos
2022-03-19 14:33 ` bug#50329: [PATCH v2 1/2] gnu: emacs-lsp-treemacs: Remove unclearly licensed icons r0man
2023-01-22  9:09   ` Liliana Marie Prikler
2022-03-19 15:29 ` bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Roman Scherer
2022-03-19 20:10   ` Maxime Devos
2022-03-20  8:59     ` Roman Scherer
2022-03-20  9:41       ` Maxime Devos
2022-03-20 10:35         ` Roman Scherer
2022-03-20 11:15           ` Liliana Marie Prikler [this message]
2022-03-20 11:21             ` Roman Scherer
2022-03-20 13:10               ` Liliana Marie Prikler
2022-03-20 13:58                 ` Roman Scherer
2022-03-20 15:46                   ` Liliana Marie Prikler
2022-03-20 17:58                     ` Roman Scherer
2022-03-20 13:29 ` bug#50329: [PATCH v2 2/2] gnu: emacs-company-box: Remove unclearly licensed icons from source Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c02a771f87791518ea8cfedd8ec83da343a8e5cb.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=50329@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=maximedevos@telenet.be \
    --cc=roman.scherer@burningswell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).