From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KJasMCQ5NmJjTAAAgWs5BA (envelope-from ) for ; Sat, 19 Mar 2022 21:12:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cAZvKSQ5NmKBQQAAG6o9tA (envelope-from ) for ; Sat, 19 Mar 2022 21:12:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B37F23C09 for ; Sat, 19 Mar 2022 21:12:20 +0100 (CET) Received: from localhost ([::1]:51880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVfQx-0008N5-Br for larch@yhetil.org; Sat, 19 Mar 2022 16:12:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVfQg-0008Mw-M9 for bug-guix@gnu.org; Sat, 19 Mar 2022 16:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVfQg-0003QO-DR for bug-guix@gnu.org; Sat, 19 Mar 2022 16:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVfQg-00033R-6e for bug-guix@gnu.org; Sat, 19 Mar 2022 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 19 Mar 2022 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Roman Scherer , guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164772067011676 (code B ref -1); Sat, 19 Mar 2022 20:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Mar 2022 20:11:10 +0000 Received: from localhost ([127.0.0.1]:60655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVfPq-00032F-47 for submit@debbugs.gnu.org; Sat, 19 Mar 2022 16:11:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:57548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVfPo-000328-Ns for submit@debbugs.gnu.org; Sat, 19 Mar 2022 16:11:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVfPo-0008Jv-7F for guix-patches@gnu.org; Sat, 19 Mar 2022 16:11:08 -0400 Received: from [2a02:1800:110:4::f00:18] (port=44146 helo=michel.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVfPj-0003Mn-BS for guix-patches@gnu.org; Sat, 19 Mar 2022 16:11:07 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id 8LAw2700G4UW6Th06LAwh2; Sat, 19 Mar 2022 21:10:58 +0100 Message-ID: <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> From: Maxime Devos Date: Sat, 19 Mar 2022 21:10:52 +0100 In-Reply-To: <87fsnevtxi.fsf@burningswell.com> References: <87fsnevtxi.fsf@burningswell.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xmvQ4Jy8g45EzRuI6hnw" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647720658; bh=WneAUQFrDweYmLFrfUEKL6thXKC9a1MUYDTo0wlYy+U=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=hqKmC/wAHjt/+uAiAwN1Mp9477ouOWolOJAn1SZT5Gt3N1m+jofrJhkh+Jg6jSqpM pdRDET643E9dkZotCxdzn8zYkdfUEhOp2DQKtsncOL3Cnf1HXsY7vk+FNvNBfxj1St MqaNJVHuDtWNFwFhyuxEaKA3km9dhSUd5Qv5sH79Qug33wBImGy7lVvHMEylKBMvme 84C40jA6V4wPgEi6b96CC+2Exdfaoi0LsOFuhprbwYlhnABbZhpLrZ35mss207vzDP uR84vRxDwZeBm1U1Qj28aS653PdmHnj508rCnV39ITXx1bruS6ZhgedNvjmsBJ7rJ4 C3aD1XaqnIHzg== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:110:4::f00:18 (failed) Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647720740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WneAUQFrDweYmLFrfUEKL6thXKC9a1MUYDTo0wlYy+U=; b=Nuiu5pNLwv+tnOGHTCi7zO27iRAIQgivDNTxHc2e7xuqhcekg3LTDEt1ul3HfzKQt+by/v z66RW8Man3f7E8gYkh0PXU2TuBng76UhH1K0oBPV08OlNDc7+HzRNxGf6lErTx/mTwRm8s 7foEm2ZlLGSLv3mU5XQz0ItTgSZecVqhwmJleJ8DJrVcuLHgzvcZIyCXqzy2RNvNZKQFWJ FuOdJQCtQcRkC+REyfZboRdRE/vc4vns86INg/hraDXF5n8YIeD/xUfKkIn45UCstzUDLc C9SNdlSsvtJBKVM0YBQSG+zXpG9cj6Y96RNSCfRq55qnbPLWRGk2a54MYlQzCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647720740; a=rsa-sha256; cv=none; b=CPCkvd5gv27gsyVomwlf7jDFOqsvCsXDk7dh2EjxHVrdfG/rEB/wSyiepBZRMmAjJfkPAf eZjGJVvnYqjJTUdIx/fo6BZbNuQ3q28GLMiy0TMwDlyDuDE3POFUJRmiFYvVXBIq06WAVU EOKrrAok30e7bodPZMAGcbGgdRKdbdV/CR9cIE6/NP11GK8lTOAPza3JkJ/4fGJzsFmKkq orB+3CEOD6Vu89G8RxDZnKQRHp/rK3Nrru5At+6eYEOjEO5i9NsE5/rl3OnTiiwkIONpaC FzJBPhjUsxTCn+IGEkWJoo30A1Cgu1WTI0XsV7GEULoHxkYRH1/OkYrzGsZF6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="hqKmC/wA"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b="hqKmC/wA"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7B37F23C09 X-Spam-Score: 3.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: pqSB+F3rqH/t --=-xmvQ4Jy8g45EzRuI6hnw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Roman Scherer schreef op za 19-03-2022 om 16:29 [+0100]: > the emacs-lsp-treemacs package does not bundle it's icons. This patch > fixes the issue by copying the icons to `share/emacs-lsp- > treemacs/icons` and patching the paths in `lsp-treemacs-themes.el`. That might technically solves matter, though instead of copying, why not just change (string-append "\"" out "/share/" ,name "/icons/" name "\"") to the location of the icons? Unless you meant something else with bundling here ... Also, what do you mean with bundling exactly? AFAICT, the icons _are_ bundled, in the directory 'icons', and so far they have not yet been unbundled in Guix -- the problem is that they are not installed (yet) -- in that case, the patch seems reasonable to me. Additionally, there may be some licensing problems. The icons apparently come from =E2=80=98eclipse=E2=80=99, =E2=80=98idea=E2=80=99 and = =E2=80=98netbeans=E2=80=99. I don't actually know which license these have, but: * idea is propietary, so probably its icons are as well * Eclipse is ASL, which probably has some kind of requirement that you need to preserve license and copyright information, which seems to be completely ignored here. * the relevant licenses don't appear to be entioned in the 'licenses' field. As such, if these problems are not resolved, I think it will be necessary to remove emacs-lsp-treemacs. It seems like emacs-company-box (https://github.com/sebastiencs/company-box/tree/master/images) has the same problem as well. Also seem upstream . Greetings, Maxime. --=-xmvQ4Jy8g45EzRuI6hnw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjY4zBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mptAP47XNeYT7ves7UyacUdvOptbBS2 D44/yc2qupwRyrcpfgD/Rptrs/VdWm+r6t+sEOs4wcIpoUuxHiBU5zy323IcIQc= =Bikt -----END PGP SIGNATURE----- --=-xmvQ4Jy8g45EzRuI6hnw--