From: Roman Scherer <roman.scherer@burningswell.com>
To: guix-patches@gnu.org
Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs
Date: Sat, 19 Mar 2022 16:29:54 +0100 [thread overview]
Message-ID: <87fsnevtxi.fsf@burningswell.com> (raw)
In-Reply-To: <yu1k0jzg95d.fsf@inventati.org>
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
Hello,
the emacs-lsp-treemacs package does not bundle it's icons. This patch
fixes the issue by copying the icons to `share/emacs-lsp-treemacs/icons`
and patching the paths in `lsp-treemacs-themes.el`.
This is the link to the issue in bug tracker: https://issues.guix.gnu.org/50329
Would you like to apply this patch?
Thanks, Roman.
This is my 2nd mail, because I forgot to set the subject in the previous.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 1524 bytes --]
From 70b409e51ea655c79fac20d9990b9644ddd4f19c Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sat, 19 Mar 2022 15:33:24 +0100
Subject: [PATCH] Bundle emacs-lsp-treemacs icons
---
gnu/packages/emacs-xyz.scm | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dcd36291fb..a1328ef57a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24429,6 +24429,19 @@ (define-public emacs-lsp-treemacs
(sha256
(base32 "05ivqa5900139jzjhwc3nggwznhm8564dz4ydcxym2ddd63571k0"))))
(build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'patch-paths
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* "lsp-treemacs-themes.el"
+ (("\\(f-join \\(f-dirname \\(or load-file-name buffer-file-name\\)\\) \"icons/([^\"]+)\"\\)" all name)
+ (string-append "\"" out "/share/" ,name "/icons/" name "\""))))))
+ (add-after 'install 'install-data
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (copy-recursively "icons" (string-append out "/share/" ,name "/icons"))))))))
(propagated-inputs
(list emacs-lsp-mode emacs-treemacs))
(home-page "https://github.com/emacs-lsp/lsp-treemacs")
--
2.34.0
next prev parent reply other threads:[~2022-03-19 19:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 23:31 bug#50329: Missing icon folder in emacs-lsp-treemacs package Cayetano Santos
2022-03-19 14:33 ` bug#50329: [PATCH v2 1/2] gnu: emacs-lsp-treemacs: Remove unclearly licensed icons r0man
2023-01-22 9:09 ` Liliana Marie Prikler
2022-03-19 15:29 ` Roman Scherer [this message]
2022-03-19 20:10 ` bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Maxime Devos
2022-03-20 8:59 ` Roman Scherer
2022-03-20 9:41 ` Maxime Devos
2022-03-20 10:35 ` Roman Scherer
2022-03-20 11:15 ` Liliana Marie Prikler
2022-03-20 11:21 ` Roman Scherer
2022-03-20 13:10 ` Liliana Marie Prikler
2022-03-20 13:58 ` Roman Scherer
2022-03-20 15:46 ` Liliana Marie Prikler
2022-03-20 17:58 ` Roman Scherer
2022-03-20 13:29 ` bug#50329: [PATCH v2 2/2] gnu: emacs-company-box: Remove unclearly licensed icons from source Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsnevtxi.fsf@burningswell.com \
--to=roman.scherer@burningswell.com \
--cc=guix-patches@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).