* bug#36517: 'guix deploy' does not restart services
@ 2019-07-05 23:23 Jakob L. Kreuze
2019-07-11 15:32 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: Jakob L. Kreuze @ 2019-07-05 23:23 UTC (permalink / raw)
To: 36517
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
This issue is described in more detail at [1]. Essentially, 'guix
deploy' is will happily load and start new services, as well as unload
obsolete services, but does nothing to restart valid services that are
already running.
I can assign myself to this issue. Just filing for tracking purposes :]
Regards,
Jakob
[1]: https://lists.gnu.org/archive/html/guix-patches/2019-06/msg00567.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-07-05 23:23 bug#36517: 'guix deploy' does not restart services Jakob L. Kreuze
@ 2019-07-11 15:32 ` Ludovic Courtès
2019-07-11 17:05 ` Jakob L. Kreuze
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2019-07-11 15:32 UTC (permalink / raw)
To: Jakob L. Kreuze; +Cc: 36517
Hi,
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> This issue is described in more detail at [1]. Essentially, 'guix
> deploy' is will happily load and start new services, as well as unload
> obsolete services, but does nothing to restart valid services that are
> already running.
That’s not a bug: ‘guix system reconfigure’ does not restart already
running services, simply because it cannot tell whether now is a good
time to restart them. It’s a decision that’s left to the system
administrator.
However, note that ‘guix system reconfigure’ loads “replacements” for
each Shepherd service, such that next time you run ‘herd restart FOO’,
you spawn that new version of FOO.
Does that make sense?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-07-11 15:32 ` Ludovic Courtès
@ 2019-07-11 17:05 ` Jakob L. Kreuze
2019-07-12 20:43 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: Jakob L. Kreuze @ 2019-07-11 17:05 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 36517
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
Hi, Ludovic!
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
>
>> This issue is described in more detail at [1]. Essentially, 'guix
>> deploy' is will happily load and start new services, as well as unload
>> obsolete services, but does nothing to restart valid services that are
>> already running.
>
> That’s not a bug: ‘guix system reconfigure’ does not restart already
> running services, simply because it cannot tell whether now is a good
> time to restart them. It’s a decision that’s left to the system
> administrator.
>
> However, note that ‘guix system reconfigure’ loads “replacements” for
> each Shepherd service, such that next time you run ‘herd restart FOO’,
> you spawn that new version of FOO.
>
> Does that make sense?
Yes, that does make sense. I suppose the way I worded the initial report
wasn't great; I opened this to track support for 'restart-strategy' as
described in #33508 in 'guix deploy'. This takes care of the question of
when a good time to restart the service would be.
Regards,
Jakob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-07-11 17:05 ` Jakob L. Kreuze
@ 2019-07-12 20:43 ` Ludovic Courtès
2019-07-13 17:14 ` Jakob L. Kreuze
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2019-07-12 20:43 UTC (permalink / raw)
To: Jakob L. Kreuze; +Cc: 36517
Howdy!
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
>>
>>> This issue is described in more detail at [1]. Essentially, 'guix
>>> deploy' is will happily load and start new services, as well as unload
>>> obsolete services, but does nothing to restart valid services that are
>>> already running.
>>
>> That’s not a bug: ‘guix system reconfigure’ does not restart already
>> running services, simply because it cannot tell whether now is a good
>> time to restart them. It’s a decision that’s left to the system
>> administrator.
>>
>> However, note that ‘guix system reconfigure’ loads “replacements” for
>> each Shepherd service, such that next time you run ‘herd restart FOO’,
>> you spawn that new version of FOO.
>>
>> Does that make sense?
>
> Yes, that does make sense. I suppose the way I worded the initial report
> wasn't great; I opened this to track support for 'restart-strategy' as
> described in #33508 in 'guix deploy'. This takes care of the question of
> when a good time to restart the service would be.
Oh, I see. To me that’s completely orthogonal to ‘guix deploy’ though,
in that ‘guix system reconfigure’ and ‘guix deploy’ should use the same
code for that.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-07-12 20:43 ` Ludovic Courtès
@ 2019-07-13 17:14 ` Jakob L. Kreuze
2019-08-24 13:22 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: Jakob L. Kreuze @ 2019-07-13 17:14 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 36517
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
Heyo,
Ludovic Courtès <ludo@gnu.org> writes:
> Oh, I see. To me that’s completely orthogonal to ‘guix deploy’ though,
> in that ‘guix system reconfigure’ and ‘guix deploy’ should use the
> same code for that.
>
> Thanks,
> Ludo’.
Yeah, I believe it would be safe to close this once the code for 'guix
deploy' and 'guix system reconfigure' is unified. I opened this under
the impression that the two would remain separate and individual changes
would need to occur for both.
Regards,
Jakob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-07-13 17:14 ` Jakob L. Kreuze
@ 2019-08-24 13:22 ` Ludovic Courtès
2019-08-24 17:44 ` Jakob L. Kreuze
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2019-08-24 13:22 UTC (permalink / raw)
To: Jakob L. Kreuze; +Cc: 36517
Hi Jakob,
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Oh, I see. To me that’s completely orthogonal to ‘guix deploy’ though,
>> in that ‘guix system reconfigure’ and ‘guix deploy’ should use the
>> same code for that.
>>
>> Thanks,
>> Ludo’.
>
> Yeah, I believe it would be safe to close this once the code for 'guix
> deploy' and 'guix system reconfigure' is unified. I opened this under
> the impression that the two would remain separate and individual changes
> would need to occur for both.
Unless I’m mistaken, this bug can be closed now, right?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-08-24 13:22 ` Ludovic Courtès
@ 2019-08-24 17:44 ` Jakob L. Kreuze
2019-08-26 8:19 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: Jakob L. Kreuze @ 2019-08-24 17:44 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 36517
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Unless I’m mistaken, this bug can be closed now, right?
Yep! This can be closed now, since we're running the unified code and we
have another ticket for tracking this in 'guix system reconfigure'.
Regards,
Jakob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#36517: 'guix deploy' does not restart services
2019-08-24 17:44 ` Jakob L. Kreuze
@ 2019-08-26 8:19 ` Ludovic Courtès
0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2019-08-26 8:19 UTC (permalink / raw)
To: Jakob L. Kreuze; +Cc: 36517-done
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Unless I’m mistaken, this bug can be closed now, right?
>
> Yep! This can be closed now, since we're running the unified code and we
> have another ticket for tracking this in 'guix system reconfigure'.
Alrighty, done!
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-26 8:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 23:23 bug#36517: 'guix deploy' does not restart services Jakob L. Kreuze
2019-07-11 15:32 ` Ludovic Courtès
2019-07-11 17:05 ` Jakob L. Kreuze
2019-07-12 20:43 ` Ludovic Courtès
2019-07-13 17:14 ` Jakob L. Kreuze
2019-08-24 13:22 ` Ludovic Courtès
2019-08-24 17:44 ` Jakob L. Kreuze
2019-08-26 8:19 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).