* bug#31700: Make clean deletes french manuals
@ 2018-06-03 21:13 Gábor Boskovits
2018-06-04 11:45 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Gábor Boskovits @ 2018-06-03 21:13 UTC (permalink / raw)
To: 31700, julien
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
Make clean removes:
doc/contributing.fr.texi
doc/guix.fr.texi
We had a discussion on #guix with roptat, and a few others.
I have found out, that after removing $(TRANSLATED_INFO)
from $(BUILT_SOURCES) in doc/local.mk these files are not
deleted any more. I have doubts that this is a correct fix, as
this might break dependency resolution.
I also noticed, that after running make these two files end up with
different content.
If you think this fix is ok, I will send a patch.
[-- Attachment #2: Type: text/html, Size: 664 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#31700: Make clean deletes french manuals
2018-06-03 21:13 bug#31700: Make clean deletes french manuals Gábor Boskovits
@ 2018-06-04 11:45 ` Ludovic Courtès
2018-06-04 18:30 ` Gábor Boskovits
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-06-04 11:45 UTC (permalink / raw)
To: Gábor Boskovits; +Cc: 31700
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Hi Gábor,
Gábor Boskovits <boskovits@gmail.com> skribis:
> Make clean removes:
> doc/contributing.fr.texi
> doc/guix.fr.texi
>
> We had a discussion on #guix with roptat, and a few others.
> I have found out, that after removing $(TRANSLATED_INFO)
> from $(BUILT_SOURCES) in doc/local.mk these files are not
> deleted any more. I have doubts that this is a correct fix, as
> this might break dependency resolution.
>
> I also noticed, that after running make these two files end up with
> different content.
But they do get re-generated, right?
I think the issue is fixed with this patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 312 bytes --]
diff --git a/nix/local.mk b/nix/local.mk
index 4452301c6..39717711f 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -22,7 +22,7 @@
#
BUILT_SOURCES += %D%/libstore/schema.sql.hh
-CLEANFILES += $(BUILT_SOURCES)
+CLEANFILES += %D%/libstore/schema.sql.hh
noinst_LIBRARIES = libformat.a libutil.a libstore.a
[-- Attachment #3: Type: text/plain, Size: 60 bytes --]
I’ll push it if it works for you.
Thanks,
Ludo’.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#31700: Make clean deletes french manuals
2018-06-04 11:45 ` Ludovic Courtès
@ 2018-06-04 18:30 ` Gábor Boskovits
2018-06-08 13:24 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Gábor Boskovits @ 2018-06-04 18:30 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 31700
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
2018-06-04 13:45 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:
> Hi Gábor,
>
> Gábor Boskovits <boskovits@gmail.com> skribis:
>
> > Make clean removes:
> > doc/contributing.fr.texi
> > doc/guix.fr.texi
> >
> > We had a discussion on #guix with roptat, and a few others.
> > I have found out, that after removing $(TRANSLATED_INFO)
> > from $(BUILT_SOURCES) in doc/local.mk these files are not
> > deleted any more. I have doubts that this is a correct fix, as
> > this might break dependency resolution.
> >
> > I also noticed, that after running make these two files end up with
> > different content.
>
> But they do get re-generated, right?
>
> I think the issue is fixed with this patch:
>
>
>
> I’ll push it if it works for you.
>
>
Thanks, Ludo, this seems to be the correct fix. Thanks for the additional
insight.
Please push it.
> Thanks,
> Ludo’.
>
>
[-- Attachment #2: Type: text/html, Size: 1565 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-08 13:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-03 21:13 bug#31700: Make clean deletes french manuals Gábor Boskovits
2018-06-04 11:45 ` Ludovic Courtès
2018-06-04 18:30 ` Gábor Boskovits
2018-06-08 13:24 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).