bug#31700: Make clean deletes french manuals

bug#31700: Make clean deletes french manuals

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Make clean removes:
doc/contributing.fr.texi
doc/guix.fr.texi

We had a discussion on #guix with roptat, and a few others.
I have found out, that after removing $(TRANSLATED_INFO)
from $(BUILT_SOURCES) in doc/local.mk these files are not
deleted any more. I have doubts that this is a correct fix, as
this might break dependency resolution.

I also noticed, that after running make these two files end up with
different content.

If you think this fix is ok, I will send a patch.

[-- Attachment #2: Type: text/html, Size: 664 bytes --]

bug#31700: Make clean deletes french manuals

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi Gábor,

Gábor Boskovits <boskovits@gmail.com> skribis:

> Make clean removes:
> doc/contributing.fr.texi
> doc/guix.fr.texi
>
> We had a discussion on #guix with roptat, and a few others.
> I have found out, that after removing $(TRANSLATED_INFO)
> from $(BUILT_SOURCES) in doc/local.mk these files are not
> deleted any more. I have doubts that this is a correct fix, as
> this might break dependency resolution.
>
> I also noticed, that after running make these two files end up with
> different content.

But they do get re-generated, right?

I think the issue is fixed with this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 312 bytes --]

diff --git a/nix/local.mk b/nix/local.mk
index 4452301c6..39717711f 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -22,7 +22,7 @@
 #
 
 BUILT_SOURCES += %D%/libstore/schema.sql.hh
-CLEANFILES += $(BUILT_SOURCES)
+CLEANFILES += %D%/libstore/schema.sql.hh
 
 noinst_LIBRARIES = libformat.a libutil.a libstore.a
 

[-- Attachment #3: Type: text/plain, Size: 60 bytes --]


I’ll push it if it works for you.

Thanks,
Ludo’.

bug#31700: Make clean deletes french manuals

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

2018-06-04 13:45 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:

> Hi Gábor,
>
> Gábor Boskovits <boskovits@gmail.com> skribis:
>
> > Make clean removes:
> > doc/contributing.fr.texi
> > doc/guix.fr.texi
> >
> > We had a discussion on #guix with roptat, and a few others.
> > I have found out, that after removing $(TRANSLATED_INFO)
> > from $(BUILT_SOURCES) in doc/local.mk these files are not
> > deleted any more. I have doubts that this is a correct fix, as
> > this might break dependency resolution.
> >
> > I also noticed, that after running make these two files end up with
> > different content.
>
> But they do get re-generated, right?
>
> I think the issue is fixed with this patch:
>
>
>
> I’ll push it if it works for you.
>
>
Thanks, Ludo, this seems to be the correct fix. Thanks for the additional
insight.
Please push it.


> Thanks,
> Ludo’.
>
>

[-- Attachment #2: Type: text/html, Size: 1565 bytes --]

bug#31700: Make clean deletes french manuals

[Ludovic Courtès]

Gábor Boskovits <boskovits@gmail.com> skribis:

> Thanks, Ludo, this seems to be the correct fix. Thanks for the additional
> insight.
> Please push it.

Pushed as 751164bca1030dfd14f9fa7508c03eb4b41173e4, thanks!

Ludo’.