From: ludo@gnu.org (Ludovic Courtès)
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: 31700@debbugs.gnu.org
Subject: bug#31700: Make clean deletes french manuals
Date: Mon, 04 Jun 2018 13:45:33 +0200 [thread overview]
Message-ID: <87r2lmrd0i.fsf@gnu.org> (raw)
In-Reply-To: <CAE4v=pgkeQ62qzgCYq3b8CVuwQn88YQEQGjZkdAKtP6HcR+Ymg@mail.gmail.com> ("Gábor Boskovits"'s message of "Sun, 3 Jun 2018 23:13:22 +0200")
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Hi Gábor,
Gábor Boskovits <boskovits@gmail.com> skribis:
> Make clean removes:
> doc/contributing.fr.texi
> doc/guix.fr.texi
>
> We had a discussion on #guix with roptat, and a few others.
> I have found out, that after removing $(TRANSLATED_INFO)
> from $(BUILT_SOURCES) in doc/local.mk these files are not
> deleted any more. I have doubts that this is a correct fix, as
> this might break dependency resolution.
>
> I also noticed, that after running make these two files end up with
> different content.
But they do get re-generated, right?
I think the issue is fixed with this patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 312 bytes --]
diff --git a/nix/local.mk b/nix/local.mk
index 4452301c6..39717711f 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -22,7 +22,7 @@
#
BUILT_SOURCES += %D%/libstore/schema.sql.hh
-CLEANFILES += $(BUILT_SOURCES)
+CLEANFILES += %D%/libstore/schema.sql.hh
noinst_LIBRARIES = libformat.a libutil.a libstore.a
[-- Attachment #3: Type: text/plain, Size: 60 bytes --]
I’ll push it if it works for you.
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-06-04 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 21:13 bug#31700: Make clean deletes french manuals Gábor Boskovits
2018-06-04 11:45 ` Ludovic Courtès [this message]
2018-06-04 18:30 ` Gábor Boskovits
2018-06-08 13:24 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2lmrd0i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31700@debbugs.gnu.org \
--cc=boskovits@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).