From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 56799@debbugs.gnu.org
Cc: attila@lendvai.name
Subject: bug#56799: (gnu services configuration) usage of *unspecified* is problematic
Date: Wed, 27 Jul 2022 12:23:58 -0400 [thread overview]
Message-ID: <87o7xa8qxt.fsf@gmail.com> (raw)
Hello Guix,
Since commit 8cb1a49a3998c39f315a4199b7d4a121a6d66449, the
define-configuration machinery in (gnu services configuration) uses
*unspecified* instead of 'disabled for an unspecified field value.
While this is indeed an improvement in readability, it introduces an
extra complication: because this new value is not self-quoting, it
cannot be used as is in G-Exps, and values using it must be carefully
expanded outside the gexp context, which is error prone.
This broke the jami-service-type, when partially specifying a
jami-account like so:
--8<---------------cut here---------------start------------->8---
(service jami-service-type
(jami-configuration
(accounts
(list (jami-account
(archive "/etc/jami/some-jami-account.gz"))))))
--8<---------------cut here---------------end--------------->8---
When building the operating system containing the above fragment, the
following error is throw:
--8<---------------cut here---------------start------------->8---
guix system: error: #<unspecified>: invalid G-expression input
--8<---------------cut here---------------end--------------->8---
The following change to the jami-provisioning test can also reproduce
the problem:
--8<---------------cut here---------------start------------->8---
modified gnu/tests/telephony.scm
@@ -60,7 +60,7 @@ (define %moderators '("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
(define %dummy-jami-account (jami-account
(archive %dummy-jami-account-archive)
(allowed-contacts %allowed-contacts)
- (moderators %moderators)
+; (moderators %moderators)
(rendezvous-point? #t)
(peer-discovery? #f)
(bootstrap-hostnames '("bootstrap.me"
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
$ make check-system TESTS=jami-provisioning
Selected 1 system tests...
guix build: error: #<unspecified>: invalid G-expression input
make: *** [Makefile:6734: check-system] Error 1
--8<---------------cut here---------------end--------------->8---
I'd suggest we revisit 8cb1a49a3998c39f315a4199b7d4a121a6d66449 to use
'unspecified (the symbol) instead of *unspecified*, which *can* be
serialized without any fuss in gexps.
Thoughts?
Thanks,
Maxim
next reply other threads:[~2022-07-27 17:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:23 Maxim Cournoyer [this message]
2022-07-27 16:43 ` bug#56799: (gnu services configuration) usage of *unspecified* is problematic Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-07-27 18:27 ` Attila Lendvai
2022-07-28 15:15 ` Maxim Cournoyer
2022-07-27 18:31 ` Maxim Cournoyer
2022-07-27 18:45 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-07-27 19:09 ` Maxim Cournoyer
2022-07-27 19:45 ` bug#56799: [PATCH] services: configuration: Step back from *unspecified* Maxim Cournoyer
2022-07-27 19:46 ` bug#56799: (gnu services configuration) usage of *unspecified* is problematic Maxim Cournoyer
2022-07-27 20:20 ` bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input Maxim Cournoyer
2022-07-27 21:43 ` Maxime Devos
2022-07-28 14:58 ` Maxim Cournoyer
2022-07-28 4:41 ` bug#56799: [PATCH v3] " Maxim Cournoyer
2022-08-01 5:08 ` bug#56799: (gnu services configuration) usage of *unspecified* is problematic Maxim Cournoyer
2022-08-01 10:00 ` Maxime Devos
2022-08-01 12:46 ` Maxim Cournoyer
2022-08-01 13:44 ` Ludovic Courtès
2022-08-01 16:55 ` Maxim Cournoyer
2022-07-28 4:55 ` bokr
2022-07-28 10:26 ` Maxime Devos
2022-07-28 15:09 ` Maxim Cournoyer
2022-08-01 13:49 ` Ludovic Courtès
2022-08-01 15:55 ` Maxim Cournoyer
2022-08-02 7:31 ` Ludovic Courtès
2022-08-02 8:45 ` bokr
2022-08-02 15:06 ` Maxim Cournoyer
2022-08-04 12:19 ` Ludovic Courtès
2022-08-07 22:44 ` Ludovic Courtès
2022-08-08 22:27 ` Attila Lendvai
2022-08-08 23:35 ` Attila Lendvai
2022-08-10 2:17 ` Maxim Cournoyer
2022-08-10 3:26 ` Maxim Cournoyer
2022-08-11 10:15 ` Attila Lendvai
2022-08-13 6:31 ` Maxim Cournoyer
2022-08-13 16:47 ` Attila Lendvai
2022-08-14 2:57 ` Maxim Cournoyer
2022-08-16 14:00 ` Attila Lendvai
2022-08-17 13:16 ` Maxim Cournoyer
2022-08-17 16:00 ` paren--- via Bug reports for GNU Guix
2022-08-10 0:43 ` Maxim Cournoyer
2022-08-24 12:40 ` bug#56799: [PATCH 1/5] services: configuration: Add a 'maybe-value-set?' procedure Attila Lendvai
2022-08-24 12:40 ` bug#56799: [PATCH 2/5] services: configuration: Add %unset-value exported variable Attila Lendvai
2022-08-24 12:40 ` bug#56799: [PATCH 3/5] services: configuration: Add maybe-value exported procedure Attila Lendvai
2022-08-24 12:40 ` bug#56799: [PATCH 4/5] services: Use the new maybe/unset API Attila Lendvai
2022-08-25 4:18 ` bug#56799: (gnu services configuration) usage of *unspecified* is problematic Maxim Cournoyer
2022-08-24 12:40 ` bug#56799: [PATCH 5/5] services: configuration: Change the value of the unset marker Attila Lendvai
2022-08-25 4:14 ` bug#56799: (gnu services configuration) usage of *unspecified* is problematic Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7xa8qxt.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=56799@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).