From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4MfDOQdx4WKRBgAAbAwnHQ (envelope-from ) for ; Wed, 27 Jul 2022 19:08:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6L/SOQdx4WIVYwEA9RJhRA (envelope-from ) for ; Wed, 27 Jul 2022 19:08:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0F162FFA6 for ; Wed, 27 Jul 2022 19:08:23 +0200 (CEST) Received: from localhost ([::1]:35096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGjqu-0005L0-GL for larch@yhetil.org; Wed, 27 Jul 2022 12:25:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGjqL-0005KN-MR for bug-guix@gnu.org; Wed, 27 Jul 2022 12:25:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGjqK-0005v3-05 for bug-guix@gnu.org; Wed, 27 Jul 2022 12:25:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGjqI-0000sp-J1 for bug-guix@gnu.org; Wed, 27 Jul 2022 12:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56799: (gnu services configuration) usage of *unspecified* is problematic Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 27 Jul 2022 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56799 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 56799@debbugs.gnu.org Cc: attila@lendvai.name X-Debbugs-Original-To: bug-guix Received: via spool by submit@debbugs.gnu.org id=B.16589390473305 (code B ref -1); Wed, 27 Jul 2022 16:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jul 2022 16:24:07 +0000 Received: from localhost ([127.0.0.1]:56863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGjpP-0000rE-H8 for submit@debbugs.gnu.org; Wed, 27 Jul 2022 12:24:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:49362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGjpN-0000r6-4j for submit@debbugs.gnu.org; Wed, 27 Jul 2022 12:24:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGjpL-0004Pv-Rl for bug-guix@gnu.org; Wed, 27 Jul 2022 12:24:04 -0400 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:38694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGjpJ-0005ow-PD for bug-guix@gnu.org; Wed, 27 Jul 2022 12:24:03 -0400 Received: by mail-qt1-x832.google.com with SMTP id y9so12994681qtv.5 for ; Wed, 27 Jul 2022 09:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version; bh=R2LtPJ9tnIq3qOLukHbaRB7ZX2/pkKbb5OCEJJuOuwU=; b=VzyQuzpsfTnRKgSdZq7QvLv5RPuR/208A/yXvDm6hqOW8M91fJlKiSnDWe35kYOsmA p6aAOnnQv38/5a26pXkL0Yzb9J/Cihl3rTyPcUmsCBcdpOlRYJl+N9rM3usItQSKk6WM urpTf0tr5dODzw7/dJuMdC65kHt6RSps8pQbCLBEq1loPiRKdcOKYsefe+uojDjNixIm KroTpYfdR3/nWBK31g98OIm1um1Szw6tnVlIpJxIeO34fkF6dkn+xhd5zvEUc7jPIdDp Pj5lEMDCdjrFdNPiKXqecXAyFa0D4dwjXkCCXXT2TtaL6UbCnY4ulDZsaCQ9+F+pSHx1 n9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=R2LtPJ9tnIq3qOLukHbaRB7ZX2/pkKbb5OCEJJuOuwU=; b=sUeiQaFK0sknbSNNeG+Jtg4axQMz3G8ssUPv74pQDlEIzyfBB5swzapRxNAKbFOXXM 57B47D8VucY1tQE9kopRCa0TJolg4cvMl3uneD3g394Tbi/RPjrcJQOqKT218NQKqeDw DGO1oZTj2qUcGSSxtR9Sj1+c0foAhPTFaqzVV71oPx4GE0bHPNvzdaPJx7tZNVmJJQ9m EdjW2ukot9Gfk65+jVbOoVmiQL/Z7jfLGgGIphPA8ZAHftv0NB7VnHPtnrDwt3IXWLzp UO4n1Q0Sl1GJrVSX5BEF4VLZAJjdmNWntGFR821+HXr/F3URt89+0Zy4+vhCZGfpHnEr 8vpg== X-Gm-Message-State: AJIora+yr8nMVjWM/W82Q4Q6+WyiiH0J8XHQFrVzzrUKCUm1szrtjJUG gFiilPxe44W6DkBzRJzqmpO3k0EeTE0= X-Google-Smtp-Source: AGRyM1voCY0iCRnCkJag0zqvCQgynGlUqtq2th/0GJNmewkw5Y5e5PSeIwZpVNQTz7BNx0a6RPPQEQ== X-Received: by 2002:ac8:4e8b:0:b0:31f:2671:1682 with SMTP id 11-20020ac84e8b000000b0031f26711682mr18677390qtp.527.1658939040233; Wed, 27 Jul 2022 09:24:00 -0700 (PDT) Received: from hurd (dsl-10-148-58.b2b2c.ca. [72.10.148.58]) by smtp.gmail.com with ESMTPSA id ck11-20020a05622a230b00b0031eeefd896esm10970172qtb.3.2022.07.27.09.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 09:23:59 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 27 Jul 2022 12:23:58 -0400 Message-ID: <87o7xa8qxt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658941703; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=R2LtPJ9tnIq3qOLukHbaRB7ZX2/pkKbb5OCEJJuOuwU=; b=I35eAw7ERfghs/Zvs8Y3pBPUBPYeTvtFaWyeqZvbhxNAElNmktcR+FDqIWrdBVf/8Q+vPT LzQ6sLRzfF4so9ZtsGjk/18O3eXaiRG+L4kYbvE4WRHg2A1/IVqhHgeOj3Xfpn9U5HRGF5 h3hvILwg25cNXGQdgEIfffu6XhXoGNw+OG97T8hPOmGagmjhhST3onjYg6SrV2izByr6D7 /ljioVbQDC3Olq+JUZLIc1aYVqVkusf7wK2QgMnBctxiCIhG7kRzgggRtxQKC9VBzlmdzL hkPJQqHGXbJfoaTmc4/mKqjsN4uMXOJG7UurcomF8m0l+TwKguqbr7zszpVOCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658941703; a=rsa-sha256; cv=none; b=tVFq6NprblrCc07QLw5iCPqH65hRqN+goxihJ+fx6rgeugH/kYj/XjbxM3WJ2JWImq+fzq AlWos/9XTHsSszA20ot5m76qbk2FsHtB3NtQ0WC3/RTAlgKE0ijgOWwLQXs5veoBQ4AFcI CVKcabHEaYaeBTPafiQQqMDWldi67jfL57ZuFPqBj00wnU5uSBjsrmTk/v5pBEfA+gbuPI Ik5hF/fe1d/MYVJc6/wo4ayeNC4ZAuXYZQDehHXAiU9rIrdp+ZLit6XSMzFd7mii+C1O+c if8of7C08Ozp2W0NK2Tv7KlSRiM1WFvT42tIltC6+yYk/Is6LazQpq5uToVg1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VzyQuzps; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VzyQuzps; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A0F162FFA6 X-Spam-Score: 5.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: E0eJ0TImRzhk Hello Guix, Since commit 8cb1a49a3998c39f315a4199b7d4a121a6d66449, the define-configuration machinery in (gnu services configuration) uses *unspecified* instead of 'disabled for an unspecified field value. While this is indeed an improvement in readability, it introduces an extra complication: because this new value is not self-quoting, it cannot be used as is in G-Exps, and values using it must be carefully expanded outside the gexp context, which is error prone. This broke the jami-service-type, when partially specifying a jami-account like so: --8<---------------cut here---------------start------------->8--- (service jami-service-type (jami-configuration (accounts (list (jami-account (archive "/etc/jami/some-jami-account.gz")))))) --8<---------------cut here---------------end--------------->8--- When building the operating system containing the above fragment, the following error is throw: --8<---------------cut here---------------start------------->8--- guix system: error: #: invalid G-expression input --8<---------------cut here---------------end--------------->8--- The following change to the jami-provisioning test can also reproduce the problem: --8<---------------cut here---------------start------------->8--- modified gnu/tests/telephony.scm @@ -60,7 +60,7 @@ (define %moderators '("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" (define %dummy-jami-account (jami-account (archive %dummy-jami-account-archive) (allowed-contacts %allowed-contacts) - (moderators %moderators) +; (moderators %moderators) (rendezvous-point? #t) (peer-discovery? #f) (bootstrap-hostnames '("bootstrap.me" --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- $ make check-system TESTS=jami-provisioning Selected 1 system tests... guix build: error: #: invalid G-expression input make: *** [Makefile:6734: check-system] Error 1 --8<---------------cut here---------------end--------------->8--- I'd suggest we revisit 8cb1a49a3998c39f315a4199b7d4a121a6d66449 to use 'unspecified (the symbol) instead of *unspecified*, which *can* be serialized without any fuss in gexps. Thoughts? Thanks, Maxim