From: Han-Wen Nienhuys <hanwenn@gmail.com>
To: Thien-Thi Nguyen <ttn@gnuvola.org>
Cc: Guile Devel <guile-devel@gnu.org>
Subject: Re: Guile 1.8.9 release
Date: Tue, 9 Feb 2021 09:59:07 +0100 [thread overview]
Message-ID: <CAOw_e7Zyio4kFOZxbwSaDOd24OGbOn4e7g_G33xOvd+6HFVWuw@mail.gmail.com> (raw)
In-Reply-To: <CAOw_e7ZpohtABuoPLHA53ouk0TebTWcLegmXMWJK=Kq+JU9K-w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On Sun, Jan 17, 2021 at 7:37 PM Han-Wen Nienhuys <hanwenn@gmail.com> wrote:
> On Sun, Jan 17, 2021 at 12:10 AM Thien-Thi Nguyen <ttn@gnuvola.org> wrote:
> > your timing is fortuitous. I just spent the christmas
> > holidays delving into GUILE 1.8's heap expansion strategy and
> > found and fixed a bug with it.
> >
> >
> https://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd6
> >
> > How does code review for proposed patches work these days?
> >
> > I don't know. I think what you did is fine. I invite experts
> > to review and comment. They will surely be quicker than me (i
> > will require a week or two just to read/understand the patch).
> >
> > I'd be happy to polish it up (ie. add a proper test) for
> > inclusion in GUILE 1.8.9,
> >
> > Sounds good. I think the general approach for 1.8.x releases
> > will be bugfixes and documentation changes primarily, so your
> > change would be most welcome (once i wrap my head around it).
>
> Thanks. It turns out my previous fix introduced ABI breakage, so I
> reworked it to not change function signatures or struct sizes. It's
> also split up in more parts, so it becomes easier to understand.
> Please see here:
>
>
> https://gcithub.com/hanwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516
> <https://github.com/hanwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516>
Any news here? Can I do anything to get this fix in?
--
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen
[-- Attachment #2: Type: text/html, Size: 2423 bytes --]
next prev parent reply other threads:[~2021-02-09 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 8:20 Guile 1.8.9 release Han-Wen Nienhuys
2021-01-16 23:07 ` Thien-Thi Nguyen
2021-01-17 18:37 ` Han-Wen Nienhuys
2021-02-09 8:59 ` Han-Wen Nienhuys [this message]
2021-02-10 22:17 ` Thien-Thi Nguyen
2021-02-14 10:35 ` Han-Wen Nienhuys
2021-03-14 9:34 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOw_e7Zyio4kFOZxbwSaDOd24OGbOn4e7g_G33xOvd+6HFVWuw@mail.gmail.com \
--to=hanwenn@gmail.com \
--cc=guile-devel@gnu.org \
--cc=ttn@gnuvola.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).