From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: Guile 1.8.9 release Date: Tue, 9 Feb 2021 09:59:07 +0100 Message-ID: References: <87zh18o4z7.fsf@gnuvola.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000006f27c205bae380c9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Guile Devel To: Thien-Thi Nguyen Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Tue Feb 09 10:22:53 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9PET-0009fF-7R for guile-devel@m.gmane-mx.org; Tue, 09 Feb 2021 10:22:53 +0100 Original-Received: from localhost ([::1]:44518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9PES-000279-8k for guile-devel@m.gmane-mx.org; Tue, 09 Feb 2021 04:22:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Orm-0003Tp-2A for guile-devel@gnu.org; Tue, 09 Feb 2021 03:59:26 -0500 Original-Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:40040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Ori-00072O-7w for guile-devel@gnu.org; Tue, 09 Feb 2021 03:59:25 -0500 Original-Received: by mail-ed1-x529.google.com with SMTP id s3so22479113edi.7 for ; Tue, 09 Feb 2021 00:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZrSNXLGIzasLXc0YXzteQHLUce6b3YAvabXQhgBM7jQ=; b=V8es4AZZaJpa7ZVEKYI0KxaoGYFQhrDdTEnzbIm834XzMXa6S5a1JVIpXybyK44uX7 NIl/49y+MyNhsfRR+S+xMWsulac4QVnYABkQI5XL6uRk5XzDM11ZiAq5UhOF35tuvLgV sEErsto6wPDRix4JTnMWSJN27p1CECPLOtxJFQk6sxSN3mpb6POfAm0IAhWUQsxaOcmO UVb2DLCqqiljwS1QZ27UzGqZ4H89abAcWCY3hZNG8vfUxDNt4j8K0KP8t9tlkClfix/D wgpkBQNP57UbKGlXcxX2am3gfq2zk9YJGsn8jrgKWHd9Cr78gZgnJ5+p3986Ml2Eg0Nl D3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZrSNXLGIzasLXc0YXzteQHLUce6b3YAvabXQhgBM7jQ=; b=oeXENgYNhX8GSAzqWr0A0eZMgoPIJCcYzeDvupo+s/X4YKeHldcsxX9d5NTEzieYXO DzFVfkR8P2f9N99p7fmXB/2L1A7IeUW0RGB3AA9zMpzjYWPPO9qpgdY/J0eYwVXGC1Dq PEUcTukK6kheX2DxfUpayM7w0NCD6zv3vv0Dt6bHvQ6Tegocky9jjY/44HdNG1Z0KYZ1 oVCfGxDJ+deWNZLfEU8jZ3PgTamm2xnTOKMAOG0kAAx+tQO015j84z9v+nVigYs8fJi5 mQ3rPxq9GrIcAaM+QZEFBPD4BPrnA5JtJ2QE8Emzajagu+EiWtc0kmJbnm3wfwkonot7 4BvA== X-Gm-Message-State: AOAM5306ob5SRN/onAO99hvBD6kItoGBys8nHo/R0LGoLIgiqRuo0C6U si2EEoblH9zxHO7CzaqZjHQatq090jDOZ+lMILfx0pYNBxeupA== X-Google-Smtp-Source: ABdhPJxitVzpiDFOyJRG0iO7kqwzlCXqnzE0xJ02Kss4AZUYlZ4bNyKjGywsGFOTsx2eQH/4OSoI0sc2tHVkMgtvTEg= X-Received: by 2002:a05:6402:4312:: with SMTP id m18mr21780802edc.99.1612861158663; Tue, 09 Feb 2021 00:59:18 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=hanwenn@gmail.com; helo=mail-ed1-x529.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20661 Archived-At: --0000000000006f27c205bae380c9 Content-Type: text/plain; charset="UTF-8" On Sun, Jan 17, 2021 at 7:37 PM Han-Wen Nienhuys wrote: > On Sun, Jan 17, 2021 at 12:10 AM Thien-Thi Nguyen wrote: > > your timing is fortuitous. I just spent the christmas > > holidays delving into GUILE 1.8's heap expansion strategy and > > found and fixed a bug with it. > > > > > https://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd6 > > > > How does code review for proposed patches work these days? > > > > I don't know. I think what you did is fine. I invite experts > > to review and comment. They will surely be quicker than me (i > > will require a week or two just to read/understand the patch). > > > > I'd be happy to polish it up (ie. add a proper test) for > > inclusion in GUILE 1.8.9, > > > > Sounds good. I think the general approach for 1.8.x releases > > will be bugfixes and documentation changes primarily, so your > > change would be most welcome (once i wrap my head around it). > > Thanks. It turns out my previous fix introduced ABI breakage, so I > reworked it to not change function signatures or struct sizes. It's > also split up in more parts, so it becomes easier to understand. > Please see here: > > > https://gcithub.com/hanwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516 > Any news here? Can I do anything to get this fix in? -- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen --0000000000006f27c205bae380c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 17, 2021 at 7:37 PM Han-W= en Nienhuys <hanwenn@gmail.com&= gt; wrote:
On Su= n, Jan 17, 2021 at 12:10 AM Thien-Thi Nguyen <ttn@gnuvola.org> wrote:
>=C2=A0 =C2=A0 your timing is fortuitous. I just spent the christmas
>=C2=A0 =C2=A0 holidays delving into GUILE 1.8's heap expansion stra= tegy and
>=C2=A0 =C2=A0 found and fixed a bug with it.
>
>=C2=A0 =C2=A0 htt= ps://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd= 6
>
>=C2=A0 =C2=A0 How does code review for proposed patches work these days= ?
>
> I don't know.=C2=A0 I think what you did is fine.=C2=A0 I invite e= xperts
> to review and comment.=C2=A0 They will surely be quicker than me (i > will require a week or two just to read/understand the patch).
>
>=C2=A0 =C2=A0 I'd be happy to polish it up (ie. add a proper test) = for
>=C2=A0 =C2=A0 inclusion in GUILE 1.8.9,
>
> Sounds good.=C2=A0 I think the general approach for 1.8.x releases
> will be bugfixes and documentation changes primarily, so your
> change would be most welcome (once i wrap my head around it).

Thanks. It turns out my previous fix introduced ABI breakage, so I
reworked it to not change function signatures or struct sizes. It's
also split up in more parts, so it becomes easier to understand.
Please see here:

https://gcithub.com/h= anwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516


Any news here? Can I do anything to get= this fix in?

--
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen
--0000000000006f27c205bae380c9--