unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: Han-Wen Nienhuys <hanwenn@gmail.com>
Cc: Guile Devel <guile-devel@gnu.org>
Subject: Re: Guile 1.8.9 release
Date: Wed, 10 Feb 2021 17:17:59 -0500	[thread overview]
Message-ID: <8735y3tvmw.fsf@gnuvola.org> (raw)
In-Reply-To: <CAOw_e7Zyio4kFOZxbwSaDOd24OGbOn4e7g_G33xOvd+6HFVWuw@mail.gmail.com> (Han-Wen Nienhuys's message of "Tue, 9 Feb 2021 09:59:07 +0100")

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]


() Han-Wen Nienhuys <hanwenn@gmail.com>
() Tue, 9 Feb 2021 09:59:07 +0100

   > Thanks. It turns out my previous fix introduced ABI
   > breakage, so I reworked it to not change function
   > signatures or struct sizes. It's also split up in more
   > parts, so it becomes easier to understand.  Please see
   > here: [...]

   Any news here? Can I do anything to get this fix in?

IIUC, the second iteration achieves the same goals as the first
one (i.e., reducing unnecessary allocation by refining the heap
monitoring machinery).  Is that correct?  (What am i missing?)

I would be happy to commit the second patch, if you could refine
it to add the extensive explanation of the first.  (You could
even mention the first approach, as an interesting but misguided
dead end.)  That way, we have a full record.

I would be extremely happy to commit a test along w/ the change,
if we can figure that out.  But it's not critical (we can do it
later).

Re testing, i don't know how to go about setting up a test to
avoid regressions.  (IIUC, this is a performance-related change
and not a functionality-related one.)  Any ideas?

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)               ; (2021) Software Libero
   (pcase (context query)               ;       = Dissenso Etico
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 219 bytes --]

  reply	other threads:[~2021-02-10 22:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  8:20 Guile 1.8.9 release Han-Wen Nienhuys
2021-01-16 23:07 ` Thien-Thi Nguyen
2021-01-17 18:37   ` Han-Wen Nienhuys
2021-02-09  8:59     ` Han-Wen Nienhuys
2021-02-10 22:17       ` Thien-Thi Nguyen [this message]
2021-02-14 10:35         ` Han-Wen Nienhuys
2021-03-14  9:34           ` Han-Wen Nienhuys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735y3tvmw.fsf@gnuvola.org \
    --to=ttn@gnuvola.org \
    --cc=guile-devel@gnu.org \
    --cc=hanwenn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).