From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: Han-Wen Nienhuys <hanwenn@gmail.com>
Cc: Guile Devel <guile-devel@gnu.org>
Subject: Re: Guile 1.8.9 release
Date: Sat, 16 Jan 2021 18:07:56 -0500 [thread overview]
Message-ID: <87zh18o4z7.fsf@gnuvola.org> (raw)
In-Reply-To: <CAOw_e7Zh6Mr=7dDqT6kXHEHN=o_LjdFb7s5wV04J930d7XgVtQ@mail.gmail.com> (Han-Wen Nienhuys's message of "Tue, 12 Jan 2021 09:20:55 +0100")
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
() Han-Wen Nienhuys <hanwenn@gmail.com>
() Tue, 12 Jan 2021 09:20:55 +0100
your timing is fortuitous. I just spent the christmas
holidays delving into GUILE 1.8's heap expansion strategy and
found and fixed a bug with it.
https://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd6
How does code review for proposed patches work these days?
I don't know. I think what you did is fine. I invite experts
to review and comment. They will surely be quicker than me (i
will require a week or two just to read/understand the patch).
I'd be happy to polish it up (ie. add a proper test) for
inclusion in GUILE 1.8.9,
Sounds good. I think the general approach for 1.8.x releases
will be bugfixes and documentation changes primarily, so your
change would be most welcome (once i wrap my head around it).
--
Thien-Thi Nguyen -----------------------------------------------
(defun responsep (query) ; (2021) Software Libero
(pcase (context query) ; = Dissenso Etico
(`(technical ,ml) (correctp ml))
...)) 748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 219 bytes --]
next prev parent reply other threads:[~2021-01-16 23:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 8:20 Guile 1.8.9 release Han-Wen Nienhuys
2021-01-16 23:07 ` Thien-Thi Nguyen [this message]
2021-01-17 18:37 ` Han-Wen Nienhuys
2021-02-09 8:59 ` Han-Wen Nienhuys
2021-02-10 22:17 ` Thien-Thi Nguyen
2021-02-14 10:35 ` Han-Wen Nienhuys
2021-03-14 9:34 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh18o4z7.fsf@gnuvola.org \
--to=ttn@gnuvola.org \
--cc=guile-devel@gnu.org \
--cc=hanwenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).