Re: Guile 1.8.9 release

[Han-Wen Nienhuys <hanwenn@gmail.com>]

On Sun, Jan 17, 2021 at 12:10 AM Thien-Thi Nguyen <ttn@gnuvola.org> wrote:
>
>
> () Han-Wen Nienhuys <hanwenn@gmail.com>
> () Tue, 12 Jan 2021 09:20:55 +0100
>
>    your timing is fortuitous. I just spent the christmas
>    holidays delving into GUILE 1.8's heap expansion strategy and
>    found and fixed a bug with it.
>
>    https://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd6
>
>    How does code review for proposed patches work these days?
>
> I don't know.  I think what you did is fine.  I invite experts
> to review and comment.  They will surely be quicker than me (i
> will require a week or two just to read/understand the patch).
>
>    I'd be happy to polish it up (ie. add a proper test) for
>    inclusion in GUILE 1.8.9,
>
> Sounds good.  I think the general approach for 1.8.x releases
> will be bugfixes and documentation changes primarily, so your
> change would be most welcome (once i wrap my head around it).

Thanks. It turns out my previous fix introduced ABI breakage, so I
reworked it to not change function signatures or struct sizes. It's
also split up in more parts, so it becomes easier to understand.
Please see here:

https://github.com/hanwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516

-- 
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen