From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: Guile 1.8.9 release Date: Sun, 17 Jan 2021 19:37:25 +0100 Message-ID: References: <87zh18o4z7.fsf@gnuvola.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32341"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Guile Devel To: Thien-Thi Nguyen Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sun Jan 17 19:37:53 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1Cvx-0008Ld-49 for guile-devel@m.gmane-mx.org; Sun, 17 Jan 2021 19:37:53 +0100 Original-Received: from localhost ([::1]:55146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1Cvw-0006Bl-6j for guile-devel@m.gmane-mx.org; Sun, 17 Jan 2021 13:37:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1Cvk-0006Be-PZ for guile-devel@gnu.org; Sun, 17 Jan 2021 13:37:40 -0500 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:45253) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1Cvj-0006AJ-4b for guile-devel@gnu.org; Sun, 17 Jan 2021 13:37:40 -0500 Original-Received: by mail-ej1-x636.google.com with SMTP id ke15so12927109ejc.12 for ; Sun, 17 Jan 2021 10:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CIjzzLyFaAmftjmqInXgR+SstrjNq8IbSkjnogbGjFE=; b=UnieQvmkr4cIlzDgNZ6q0yfJ0fG3nLeD6MBx0amgYJysNnFbendkSDtSxWmKA2HoJ/ 0ehX6/OSNnaLnZFLf5p+x6MaSXjGSM40yxcjvkDDZttM9I/t4NM2YQu/NQRRMREXjdWi EjUgkONAzE9CpXxzKjDXQnziLfNai1cDYK25GZ4xh/xLBbX6smkpB9xJCeKCtgTtSgGy u0rn2YQzu3WHw4wgLHkcvxjskhQOliPvzNY0RrSNIjAOKxkWysFsUcnMc0alp3KxBsDy QfNrSWWG7FXrE16xm0C0NaNdOioo8aU1Em6TZNF1AvWRYAQW0QS8Wfcei99hFdajLbnR T7jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CIjzzLyFaAmftjmqInXgR+SstrjNq8IbSkjnogbGjFE=; b=Fb8tKrjurx6ib2cPc74WYcSjaiAm1A10smMvCSB6ZVlgVmStGi3lNKMhYRMxs8K+0s 8bNTjQaBwRkxOY6R6NdxSpCU5RON8hOa4laTR3IoRuTI+x2Q/HrZks6x5S8+I0gdim30 tFOI3QBA1TOfrLvZaRPtqCluZvQFXRVtSO6H5NJ6dAbEoohb8i/lexMd1BWG//UnY32g sGlnemzXIVEhL5RVevu/c1ILxGveZHRagUACTQRZcD5mRXTNHxQrfO62gDFea2pYABt+ MpqO7p4cK9D0ZVNEefYYPNs1mgwoVKk0F9K7TOZfdI+zWQIcNqkk53SrUXxIR2TWUGz6 AfPQ== X-Gm-Message-State: AOAM531vuxZj+2KNXJBbxQGuXh78CKZDq6Nd8V203+3qD0HckvONWcyB 6mRKD6rd+yb+wl9fL4Yx9+xji+kj18kL7OMT4ylltktOxN2QuA== X-Google-Smtp-Source: ABdhPJzAB398qfz9lPK0ptjRt95strGoplSqncf3gXdpwcI+/BGTicIzrGzB081h7fCW7TseBhGIMr2w3pnT+5K0dww= X-Received: by 2002:a17:906:ae51:: with SMTP id lf17mr419283ejb.330.1610908656827; Sun, 17 Jan 2021 10:37:36 -0800 (PST) In-Reply-To: <87zh18o4z7.fsf@gnuvola.org> Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=hanwenn@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20638 Archived-At: On Sun, Jan 17, 2021 at 12:10 AM Thien-Thi Nguyen wrote: > > > () Han-Wen Nienhuys > () Tue, 12 Jan 2021 09:20:55 +0100 > > your timing is fortuitous. I just spent the christmas > holidays delving into GUILE 1.8's heap expansion strategy and > found and fixed a bug with it. > > https://github.com/hanwen/guile/commit/9b32504780e0b604196be866b8c36079891e3cd6 > > How does code review for proposed patches work these days? > > I don't know. I think what you did is fine. I invite experts > to review and comment. They will surely be quicker than me (i > will require a week or two just to read/understand the patch). > > I'd be happy to polish it up (ie. add a proper test) for > inclusion in GUILE 1.8.9, > > Sounds good. I think the general approach for 1.8.x releases > will be bugfixes and documentation changes primarily, so your > change would be most welcome (once i wrap my head around it). Thanks. It turns out my previous fix introduced ABI breakage, so I reworked it to not change function signatures or struct sizes. It's also split up in more parts, so it becomes easier to understand. Please see here: https://github.com/hanwen/guile/commit/8fbe3222cac4b4e9b39a6a3570ac43f160faa516 -- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen