* How to get pull-request feedback
@ 2024-03-27 1:37 Ryan Raymond
2024-03-27 14:15 ` Maxime Devos
0 siblings, 1 reply; 3+ messages in thread
From: Ryan Raymond @ 2024-03-27 1:37 UTC (permalink / raw)
To: guile-devel
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
Hello,
I am trying to contribute to Guile but I cannot figure out how I am
supposed to do it. I submitted a pull request, but I cannot see the status
of that request on cgit. Do we even use pull requests or do we do pushes?
So I need to get put on the member list by filing a request for inclusion?
There are limitations to the language that have forced me to use a modified
version to complete my projects and I would be thrilled to share those
enhancements with the community.
Does anyone have any advice in this regard?
Ryan
[-- Attachment #2: Type: text/html, Size: 610 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: How to get pull-request feedback
2024-03-27 1:37 How to get pull-request feedback Ryan Raymond
@ 2024-03-27 14:15 ` Maxime Devos
2024-03-27 23:17 ` Ryan Raymond
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Devos @ 2024-03-27 14:15 UTC (permalink / raw)
To: Ryan Raymond, guile-devel@gnu.org
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
>I am trying to contribute to Guile but I cannot figure out how I am supposed to do it. I submitted a pull request, but I cannot see the status of that request on cgit. Do we even use pull requests or do we do pushes? So I need to get put on the member list by filing a request for inclusion?
Where can people find this pull request? Like, is this a ‘git request-pull’-style PR send by e-mail, a ‘git request-pull’-style PR that was formatted by ‘git request-pull’ but you forgot to send, a PR on an unofficial GitHub mirror that almost nobody looks at, some Savannah feature unknown to me, or ...
> do we do pushes?
If with this you mean that people with contributions directly push it to the main branch: no.
> So I need to get put on the member list by filing a request for inclusion?
No.
I have done contributions in the past without having an account on Savannah and without any kind of administration – I just send patches to guile-devel@gnu.org with a cover message. (Or without cover message if it’s just a single patch.)
Best regards,
Maxime Devos.
[-- Attachment #2: Type: text/html, Size: 4769 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: How to get pull-request feedback
2024-03-27 14:15 ` Maxime Devos
@ 2024-03-27 23:17 ` Ryan Raymond
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Raymond @ 2024-03-27 23:17 UTC (permalink / raw)
To: Maxime Devos; +Cc: guile-devel
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
Oh I'm so embarrassed. I thought git pull-request sent an email to the git
server the same way one might push changes. I didn't realize I would need
to copy that pull request message and send it as an email. Thanks Maxime. I
feel like you've really done a lot to help me out and I appreciate it.
On Wed, Mar 27, 2024, 10:15 AM Maxime Devos <maximedevos@telenet.be> wrote:
> >I am trying to contribute to Guile but I cannot figure out how I am
> supposed to do it. I submitted a pull request, but I cannot see the status
> of that request on cgit. Do we even use pull requests or do we do pushes?
> So I need to get put on the member list by filing a request for inclusion?
>
>
>
> Where can people find this pull request? Like, is this a ‘git
> request-pull’-style PR send by e-mail, a ‘git request-pull’-style PR that
> was formatted by ‘git request-pull’ but you forgot to send, a PR on an
> unofficial GitHub mirror that almost nobody looks at, some Savannah feature
> unknown to me, or ...
>
>
>
> > do we do pushes?
>
>
>
> If with this you mean that people with contributions directly push it to
> the main branch: no.
>
>
>
> > So I need to get put on the member list by filing a request for
> inclusion?
>
>
>
> No.
>
>
>
> I have done contributions in the past without having an account on
> Savannah and without any kind of administration – I just send patches to
> guile-devel@gnu.org with a cover message. (Or without cover message if
> it’s just a single patch.)
>
>
>
> Best regards,
>
> Maxime Devos.
>
[-- Attachment #2: Type: text/html, Size: 2508 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-27 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-27 1:37 How to get pull-request feedback Ryan Raymond
2024-03-27 14:15 ` Maxime Devos
2024-03-27 23:17 ` Ryan Raymond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).