unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Ryan Raymond <rjraymond@oakland.edu>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guile-devel@gnu.org
Subject: Re: How to get pull-request feedback
Date: Wed, 27 Mar 2024 19:17:06 -0400	[thread overview]
Message-ID: <CAGvJ-HTYgy_6h5_fNwHBL9RXw2yp8pdfb74q_L9dMGDXT41XYQ@mail.gmail.com> (raw)
In-Reply-To: <20240327151542.3qFi2C0014Yif5G01qFiiT@laurent.telenet-ops.be>

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

Oh I'm so embarrassed. I thought git pull-request sent an email to the git
server the same way one might push changes. I didn't realize I would need
to copy that pull request message and send it as an email. Thanks Maxime. I
feel like you've really done a lot to help me out and I appreciate it.

On Wed, Mar 27, 2024, 10:15 AM Maxime Devos <maximedevos@telenet.be> wrote:

> >I am trying to contribute to Guile but I cannot figure out how I am
> supposed to do it. I submitted a pull request, but I cannot see the status
> of that request on cgit. Do we even use pull requests or do we do pushes?
> So I need to get put on the member list by filing a request for inclusion?
>
>
>
> Where can people find this pull request?  Like, is this a ‘git
> request-pull’-style PR send by e-mail, a ‘git request-pull’-style PR that
> was formatted by ‘git request-pull’ but you forgot to send, a PR on an
> unofficial GitHub mirror that almost nobody looks at, some Savannah feature
> unknown to me, or ...
>
>
>
> > do we do pushes?
>
>
>
> If with this you mean that people with contributions directly push it to
> the main branch: no.
>
>
>
> > So I need to get put on the member list by filing a request for
> inclusion?
>
>
>
> No.
>
>
>
> I have done contributions in the past without having an account on
> Savannah and without any kind of administration – I just send patches to
> guile-devel@gnu.org with a cover message.  (Or without cover message if
> it’s just a single patch.)
>
>
>
> Best regards,
>
> Maxime Devos.
>

[-- Attachment #2: Type: text/html, Size: 2508 bytes --]

      reply	other threads:[~2024-03-27 23:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  1:37 How to get pull-request feedback Ryan Raymond
2024-03-27 14:15 ` Maxime Devos
2024-03-27 23:17   ` Ryan Raymond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGvJ-HTYgy_6h5_fNwHBL9RXw2yp8pdfb74q_L9dMGDXT41XYQ@mail.gmail.com \
    --to=rjraymond@oakland.edu \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).