From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ryan Raymond Newsgroups: gmane.lisp.guile.devel Subject: Re: How to get pull-request feedback Date: Wed, 27 Mar 2024 19:17:06 -0400 Message-ID: References: <20240327151542.3qFi2C0014Yif5G01qFiiT@laurent.telenet-ops.be> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000096b4620614ac9ba2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40336"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Thu Mar 28 00:17:48 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpcWg-000AIz-Qf for guile-devel@m.gmane-mx.org; Thu, 28 Mar 2024 00:17:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpcWJ-0007DK-BU; Wed, 27 Mar 2024 19:17:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpcWH-0007Cm-Nt for guile-devel@gnu.org; Wed, 27 Mar 2024 19:17:21 -0400 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpcWF-0003jC-Ux for guile-devel@gnu.org; Wed, 27 Mar 2024 19:17:21 -0400 Original-Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5e4613f2b56so217279a12.1 for ; Wed, 27 Mar 2024 16:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oakland.edu; s=google; t=1711581437; x=1712186237; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OWIs4SPMgq9iURwU2Kce96YsGLS88NK85gvNqnt6v/Q=; b=MvxdG+Vy7dUe0VFHvr6cuaIBfbhDUs8Vgj7kxl51ffNifAw2eb518VqGCBaUSSZssn L5opzBcVfh5EWxzWj+f3yz/BXZS/ldDU2jcDKgnGN1R3HpVk6o8yDHk79jwt36qCXe+B 6xXSDfyo++Ey7p8ZGyoR+e4AFLSwZS25xbQ28QCg+vJeUujFEqluAKVj/HuAJe2S5tcx Jfs/Ps5AHK+XA9fp12G/9RrV5TYlJeTsjPmnIRjNccUtAH0fQP3HpMvC/sFvC1at3BXE ILYrSrNwd6Y6jBpOW3/2QiDqE6J7pbGx4SNuotpWLAWSpvFz9+sRIfnOmZpuZk/F7IfV yJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711581437; x=1712186237; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OWIs4SPMgq9iURwU2Kce96YsGLS88NK85gvNqnt6v/Q=; b=qPVTviEQIy8YiF631d35aJzBUPKAd443ATWNi4D89MzSzfObTjm4DDTeghF30/26pi srO3ltxtAOMRlgg2zczYstN9Yk+oMDP1x/851+CAKiSYxlSfT0kKz9rG4dLxO89dJxEw p0UFIxY7AJ34wAsemx4FlEFGXqgoqma75yXGUXQmsxsvTYjBmDin09cH/JvLcwfhspQU 0JhwW1Muk+42pcZMx5PV1sR2zAiCb6pn4nCbO0ZMRM60xeELUTnVP9Nj9Hey0ShWbvbv niQPC1taLfTfmy5WyXHKsnsyb3DSwYltj7o8Gj8rqdye0QYPWwbjlcaogQYyMcxAtiH7 +zIQ== X-Gm-Message-State: AOJu0Yyto67aNsqU0hDHfNuRNJi2Lhdjru4JsW+x6E73HWyZXYvEk/qi tBXRyvZWYUbMdyfYuk/0/GpYPW+MuBdZU655eFbteKbrI38NdUtWS4xj5+L0FMGbVUK/zRyJV1u MIJrqRsub9W2ACBQlvlth1bgslmmZkrcVzM5i X-Google-Smtp-Source: AGHT+IFKY8FenohNNeVTG+iqEmVUG9QH1NkQPu2QcLZipFqbkp2ZZVNXrGHFRFkXLhtwsGuysWs9/TcZO3vgyGKQLdg= X-Received: by 2002:a05:6a20:2d2a:b0:1a3:c603:61de with SMTP id g42-20020a056a202d2a00b001a3c60361demr1790772pzl.10.1711581437501; Wed, 27 Mar 2024 16:17:17 -0700 (PDT) In-Reply-To: <20240327151542.3qFi2C0014Yif5G01qFiiT@laurent.telenet-ops.be> Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=rjraymond@oakland.edu; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22375 Archived-At: --00000000000096b4620614ac9ba2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oh I'm so embarrassed. I thought git pull-request sent an email to the git server the same way one might push changes. I didn't realize I would need to copy that pull request message and send it as an email. Thanks Maxime. I feel like you've really done a lot to help me out and I appreciate it. On Wed, Mar 27, 2024, 10:15 AM Maxime Devos wrote: > >I am trying to contribute to Guile but I cannot figure out how I am > supposed to do it. I submitted a pull request, but I cannot see the statu= s > of that request on cgit. Do we even use pull requests or do we do pushes? > So I need to get put on the member list by filing a request for inclusion= ? > > > > Where can people find this pull request? Like, is this a =E2=80=98git > request-pull=E2=80=99-style PR send by e-mail, a =E2=80=98git request-pul= l=E2=80=99-style PR that > was formatted by =E2=80=98git request-pull=E2=80=99 but you forgot to sen= d, a PR on an > unofficial GitHub mirror that almost nobody looks at, some Savannah featu= re > unknown to me, or ... > > > > > do we do pushes? > > > > If with this you mean that people with contributions directly push it to > the main branch: no. > > > > > So I need to get put on the member list by filing a request for > inclusion? > > > > No. > > > > I have done contributions in the past without having an account on > Savannah and without any kind of administration =E2=80=93 I just send pat= ches to > guile-devel@gnu.org with a cover message. (Or without cover message if > it=E2=80=99s just a single patch.) > > > > Best regards, > > Maxime Devos. > --00000000000096b4620614ac9ba2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oh I'm so embarrassed. I thought gi= t pull-request sent an email to the git server the same way one might push = changes. I didn't realize I would need to copy that pull request messag= e and send it as an email. Thanks Maxime. I feel like you've really don= e a lot to help me out and I appreciate it.

On Wed, Mar 27, 2024, 10:15 AM M= axime Devos <maximedevos@telenet.be> wrote:

>= ;I am trying to contribute to Guile but I cannot figure out how I am suppos= ed to do it. I submitted a pull request, but I cannot see the status of tha= t request on cgit. Do we even use pull requests or do we do pushes? So I ne= ed to get put on the member list by filing a request for inclusion?

=C2=A0

Where can= people find this pull request?=C2=A0 Like, is this a =E2=80=98git request-= pull=E2=80=99-style PR send by e-mail, a =E2=80=98git request-pull=E2=80=99= -style PR that was formatted by =E2=80=98git request-pull=E2=80=99 but you = forgot to send, a PR on an unofficial GitHub mirror that almost nobody look= s at, some Savannah feature unknown to me, or ...

=C2=A0

> do we do pushes?

=C2=A0

If with= this you mean that people with contributions directly push it to the main = branch: no.

=C2=A0

> So I need to get put on the member list by filing a request = for inclusion?

=C2=A0=

No.

=C2=A0

I have done contributions in the past without = having an account on Savannah and without any kind of administration =E2=80= =93 I just send patches to guile-devel@gnu.org w= ith a cover message.=C2=A0 (Or without cover message if it=E2=80=99s just a= single patch.)

=C2=A0

Best regards,

Maxime Devos.

--00000000000096b4620614ac9ba2--