From: Michael Heerdegen <michael_heerdegen@web.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org>
Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append
Date: Sat, 21 Jan 2023 15:36:04 +0100 [thread overview]
Message-ID: <87edro6jl7.fsf@web.de> (raw)
In-Reply-To: <SJ0PR10MB548869F68945DA2E1BA4CE2CF3FF9@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Tue, 10 Jan 2023 20:45:40 +0000")
[-- Attachment #1: Type: text/plain, Size: 127 bytes --]
Drew Adams <drew.adams@oracle.com> writes:
> > I think clarifying that a bit would make sense.
>
> Yes.
I tried to do that:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-files.el-minibuffer-with-setup-hook-Clarify-doc.patch --]
[-- Type: text/x-diff, Size: 1390 bytes --]
From 18a09740e4ee354954803011a7e7ded003987f77 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Sat, 21 Jan 2023 14:45:39 +0100
Subject: [PATCH] * lisp/files.el (minibuffer-with-setup-hook): Clarify
docstring
This fixes Bug#59559: Try to make clearer what kinds of s-exps are
expected as FUN argument and how they are interpreted.
---
lisp/files.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lisp/files.el b/lisp/files.el
index d308e99804d..1da77159217 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -1746,9 +1746,11 @@ confirm-nonexistent-file-or-buffer
(defmacro minibuffer-with-setup-hook (fun &rest body)
"Temporarily add FUN to `minibuffer-setup-hook' while executing BODY.
-By default, FUN is prepended to `minibuffer-setup-hook'. But if FUN is of
-the form `(:append FUN1)', FUN1 will be appended to `minibuffer-setup-hook'
-instead of prepending it.
+In the default case, FUN is an expression that should evaluate to
+a function, and the result will be prepended to
+`minibuffer-setup-hook'. If FUN is an unquoted list of the
+form `(:append FUN1)', the result of evaluating FUN1 will be
+appended to `minibuffer-setup-hook' instead of prepending it.
BODY should use the minibuffer at most once.
Recursive uses of the minibuffer are unaffected (FUN is not
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 55 bytes --]
I think this could go to emacs-29.
Thanks,
Michael.
next prev parent reply other threads:[~2023-01-21 14:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 2:55 bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Drew Adams
2022-11-25 3:07 ` Drew Adams
2023-01-10 17:37 ` Michael Heerdegen
2023-01-10 18:37 ` Drew Adams
2023-01-10 19:34 ` Michael Heerdegen
2023-01-10 19:53 ` Michael Heerdegen
2023-01-10 20:56 ` Drew Adams
2023-01-10 20:45 ` Drew Adams
2023-01-21 14:36 ` Michael Heerdegen [this message]
2023-01-21 15:35 ` Eli Zaretskii
2023-01-21 16:07 ` Michael Heerdegen
2023-01-21 18:43 ` Eli Zaretskii
2023-01-21 18:57 ` Drew Adams
2023-01-21 19:26 ` Eli Zaretskii
2023-01-21 18:51 ` Drew Adams
2023-01-21 19:23 ` Eli Zaretskii
2023-01-21 20:57 ` Drew Adams
2023-01-21 18:41 ` Drew Adams
2023-01-21 19:29 ` Eli Zaretskii
2023-01-21 20:27 ` Michael Heerdegen
2023-01-22 5:58 ` Eli Zaretskii
2023-01-22 22:10 ` Drew Adams
2023-01-22 22:19 ` Drew Adams
2023-01-23 0:15 ` Michael Heerdegen
2023-01-23 3:14 ` Drew Adams
2023-01-23 3:21 ` Drew Adams
2023-01-23 14:11 ` Michael Heerdegen
2023-01-23 16:38 ` Drew Adams
2023-01-23 12:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edro6jl7.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=59559@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.