all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 59559@debbugs.gnu.org, drew.adams@oracle.com
Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append
Date: Sat, 21 Jan 2023 17:35:16 +0200	[thread overview]
Message-ID: <83h6wjlx3f.fsf@gnu.org> (raw)
In-Reply-To: <87edro6jl7.fsf@web.de> (message from Michael Heerdegen on Sat, 21 Jan 2023 15:36:04 +0100)

> Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org>
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Date: Sat, 21 Jan 2023 15:36:04 +0100
> 
>  (defmacro minibuffer-with-setup-hook (fun &rest body)
>    "Temporarily add FUN to `minibuffer-setup-hook' while executing BODY.
> 
> -By default, FUN is prepended to `minibuffer-setup-hook'.  But if FUN is of
> -the form `(:append FUN1)', FUN1 will be appended to `minibuffer-setup-hook'
> -instead of prepending it.
> +In the default case, FUN is an expression that should evaluate to
> +a function, and the result will be prepended to
> +`minibuffer-setup-hook'.  If FUN is an unquoted list of the
> +form `(:append FUN1)', the result of evaluating FUN1 will be
> +appended to `minibuffer-setup-hook' instead of prepending it.

How about just adding the obvious to the first sentence:

  Temporarily add function FUN to `minibuffer-setup-hook' while executing BODY.

All the rest sounds clear to me, and I find the original text less
confusing than your proposed change ("expression that should evaluate
to a function"?).





  reply	other threads:[~2023-01-21 15:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  2:55 bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Drew Adams
2022-11-25  3:07 ` Drew Adams
2023-01-10 17:37   ` Michael Heerdegen
2023-01-10 18:37     ` Drew Adams
2023-01-10 19:34       ` Michael Heerdegen
2023-01-10 19:53         ` Michael Heerdegen
2023-01-10 20:56           ` Drew Adams
2023-01-10 20:45         ` Drew Adams
2023-01-21 14:36           ` Michael Heerdegen
2023-01-21 15:35             ` Eli Zaretskii [this message]
2023-01-21 16:07               ` Michael Heerdegen
2023-01-21 18:43                 ` Eli Zaretskii
2023-01-21 18:57                   ` Drew Adams
2023-01-21 19:26                     ` Eli Zaretskii
2023-01-21 18:51               ` Drew Adams
2023-01-21 19:23                 ` Eli Zaretskii
2023-01-21 20:57                   ` Drew Adams
2023-01-21 18:41             ` Drew Adams
2023-01-21 19:29               ` Eli Zaretskii
2023-01-21 20:27                 ` Michael Heerdegen
2023-01-22  5:58                   ` Eli Zaretskii
2023-01-22 22:10                     ` Drew Adams
2023-01-22 22:19                       ` Drew Adams
2023-01-23  0:15                       ` Michael Heerdegen
2023-01-23  3:14                         ` Drew Adams
2023-01-23  3:21                           ` Drew Adams
2023-01-23 14:11                           ` Michael Heerdegen
2023-01-23 16:38                             ` Drew Adams
2023-01-23 12:15                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6wjlx3f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59559@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.