From: Michael Heerdegen <michael_heerdegen@web.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org>
Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append
Date: Tue, 10 Jan 2023 18:37:50 +0100 [thread overview]
Message-ID: <87pmbmnvdd.fsf@web.de> (raw)
In-Reply-To: <SJ0PR10MB54880E7FE124E133542A7E80F30E9@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Fri, 25 Nov 2022 03:07:34 +0000")
Drew Adams <drew.adams@oracle.com> writes:
> Note that the macroexpansion is different in different
> Emacs releases. But none of them look right to me. They
> essentially produce some variant of (funcall (:append FUN)).
In master I get
#+begin_src emacs-lisp
(macroexpand-1
'(minibuffer-with-setup-hook (:append test1) (test2)))
==>
(let
((#2=#:fun test1)
(#1=#:setup-hook
(make-symbol "minibuffer-setup")))
(fset #1#
(lambda nil
(remove-hook 'minibuffer-setup-hook #1#)
(funcall #2#)))
(unwind-protect
(progn
(add-hook 'minibuffer-setup-hook #1# t)
(test2))
(remove-hook 'minibuffer-setup-hook #1#)))
#+end_src
At the first look that does not look wrong.
Michael.
next prev parent reply other threads:[~2023-01-10 17:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 2:55 bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Drew Adams
2022-11-25 3:07 ` Drew Adams
2023-01-10 17:37 ` Michael Heerdegen [this message]
2023-01-10 18:37 ` Drew Adams
2023-01-10 19:34 ` Michael Heerdegen
2023-01-10 19:53 ` Michael Heerdegen
2023-01-10 20:56 ` Drew Adams
2023-01-10 20:45 ` Drew Adams
2023-01-21 14:36 ` Michael Heerdegen
2023-01-21 15:35 ` Eli Zaretskii
2023-01-21 16:07 ` Michael Heerdegen
2023-01-21 18:43 ` Eli Zaretskii
2023-01-21 18:57 ` Drew Adams
2023-01-21 19:26 ` Eli Zaretskii
2023-01-21 18:51 ` Drew Adams
2023-01-21 19:23 ` Eli Zaretskii
2023-01-21 20:57 ` Drew Adams
2023-01-21 18:41 ` Drew Adams
2023-01-21 19:29 ` Eli Zaretskii
2023-01-21 20:27 ` Michael Heerdegen
2023-01-22 5:58 ` Eli Zaretskii
2023-01-22 22:10 ` Drew Adams
2023-01-22 22:19 ` Drew Adams
2023-01-23 0:15 ` Michael Heerdegen
2023-01-23 3:14 ` Drew Adams
2023-01-23 3:21 ` Drew Adams
2023-01-23 14:11 ` Michael Heerdegen
2023-01-23 16:38 ` Drew Adams
2023-01-23 12:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmbmnvdd.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=59559@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.