From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Date: Sat, 21 Jan 2023 15:36:04 +0100 Message-ID: <87edro6jl7.fsf@web.de> References: <87pmbmnvdd.fsf@web.de> <87358iuqsj.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5410"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 15:37:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJEzf-00019C-LR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 15:37:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJEzP-0003sH-BM; Sat, 21 Jan 2023 09:37:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJEzO-0003s9-J0 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 09:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJEzO-0005xc-B7 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 09:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJEzN-0008Qm-Sy for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 09:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59559 X-GNU-PR-Package: emacs Original-Received: via spool by 59559-submit@debbugs.gnu.org id=B59559.167431177632355 (code B ref 59559); Sat, 21 Jan 2023 14:37:01 +0000 Original-Received: (at 59559) by debbugs.gnu.org; 21 Jan 2023 14:36:16 +0000 Original-Received: from localhost ([127.0.0.1]:48395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJEye-0008Pn-Bh for submit@debbugs.gnu.org; Sat, 21 Jan 2023 09:36:16 -0500 Original-Received: from mout.web.de ([212.227.17.11]:56765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJEyc-0008PX-J4 for 59559@debbugs.gnu.org; Sat, 21 Jan 2023 09:36:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1674311765; bh=LahfUxxn2UwyHw8BPz2fesYfp3R7A//HrZC0lTStQ7I=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=HKmKNDdV/FfDyctBjDMxqPvAiHzyWTbkqAzL5G+8zyf1miwcwT77uzCbnnRZqtg0e 62oY3V0U9MaRrKTB0JLXLPRXhwIyXtm1GkCH6XzLGExOTfHhjErhL0W85RfyzRgsey g95fOOpftghqyjTm3jOCeIF1efYVr4+74Ll/yHpgBNHyYDZjqlESOedJ2b4XsdbEcO cyPev/JHM9M2mvgUnUuWxTIke7H8W5LdWzG9D2MyZhgpkPdYbYkWXKiRHSuxqZdg9I uWnxNMuLk08uM2xVqIABsV1q6SzVTpmLRlnILl7YV+zbXFmsIyKnFn2V+jxxguQlmr fmGpyQRA7doGQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MRW6Z-1p6mkz47oz-00NMdg; Sat, 21 Jan 2023 15:36:05 +0100 In-Reply-To: (Drew Adams's message of "Tue, 10 Jan 2023 20:45:40 +0000") X-Provags-ID: V03:K1:5DiZOfl4yniSNFb45x1hOAYUj3c7eaS2HVeQqcufV5Q8Zx2VC/g QemEDQWtMhn1fSxnEJDP1e9P3CKpGSc4g5ZW4lMdiALrFcbcAAyoIXnz26p5QxuId7AWB4T LWsQTMIgf5NVQGnxFoPwR+LrhKzuKf2KnNMDJfF4FasQcuhyaa92qX+AkrEcghbSrs5aE33 BmRzqHpB0tfPEA2GK1lrg== UI-OutboundReport: notjunk:1;M01:P0:AP9vtpYGG14=;HI4PlGFds5Mb/GP1zpZqmCYe6K5 p2MkZVjGvPH0DsLST+R47WI94HXBwV4GcXTGahoqRE9NrrIkjAQM9WDj+tfdsFui21TnEQcUz 2DUHQbB4OlI9JG4opUmhq8qADe6wiX5O1nZV9TMdgMkINMpIg4cbtGGb0g4HXTR2jh75sAAU5 9S23oLMWgkiAt6+oP+KrXb7HEq8jlYbg9nB8ze0c0TLuXMY9J3EajJsKS27QJLMh8RiK/KGON HwhIyJMDwXZf87MXqU0rxXtRp5SWeTmH1iNJpQdOJuzPLiFprtcInzh31X5W3/SwUFclorebK DJ+mSiok0zEh5DWVPzimqjPRAG5+pBg4praoal9EF3EIUwWa/648GD2RAIdxdVN9DlgW/fzqY 2f1czbdOtxICVFjmgT3TWzS5ZKQ6Rpx7wOMuF0z3uqYaOdkFANeHqAu3EV/Xv4JiOz03ihwpW ug5wLYjfYQFMk7deIZAoLV0PgnZRXvTSZyZ8i463WzBQpwqtlS/1KcjKAsOzuudwJvu1yN2k2 W06ejGp5N0EVofWKeShirgYwwBQU/YBgVyQHhzMdUVdeD6XwRiSvbrtSJZAitNvPrMZFCUKcE h7nvxg1cuhj6p5H83fYPoe77uptW4Qe2CyCxKI5kv5V3zo67OJQCn2oWupqfJESeXT7Cti3th 45O8sWMUt/8UFujGHebfoOHgmf7PecSZSvSv2JtmSo0yG4YTsS1lNdSAEGr9+d+QOAK1M+IBl Dev5G8/cgNWN/gShPtWl2QUHIJ8p48yVeIaRjz8PhvHRVmZfnzNqk4BtYdkb5f7cMJ5X2CQt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253865 Archived-At: --=-=-= Content-Type: text/plain Drew Adams writes: > > I think clarifying that a bit would make sense. > > Yes. I tried to do that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-files.el-minibuffer-with-setup-hook-Clarify-doc.patch Content-Transfer-Encoding: quoted-printable =46rom 18a09740e4ee354954803011a7e7ded003987f77 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Sat, 21 Jan 2023 14:45:39 +0100 Subject: [PATCH] * lisp/files.el (minibuffer-with-setup-hook): Clarify docstring This fixes Bug#59559: Try to make clearer what kinds of s-exps are expected as FUN argument and how they are interpreted. =2D-- lisp/files.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index d308e99804d..1da77159217 100644 =2D-- a/lisp/files.el +++ b/lisp/files.el @@ -1746,9 +1746,11 @@ confirm-nonexistent-file-or-buffer (defmacro minibuffer-with-setup-hook (fun &rest body) "Temporarily add FUN to `minibuffer-setup-hook' while executing BODY. -By default, FUN is prepended to `minibuffer-setup-hook'. But if FUN is o= f -the form `(:append FUN1)', FUN1 will be appended to `minibuffer-setup-hoo= k' -instead of prepending it. +In the default case, FUN is an expression that should evaluate to +a function, and the result will be prepended to +`minibuffer-setup-hook'. If FUN is an unquoted list of the +form `(:append FUN1)', the result of evaluating FUN1 will be +appended to `minibuffer-setup-hook' instead of prepending it. BODY should use the minibuffer at most once. Recursive uses of the minibuffer are unaffected (FUN is not =2D- 2.30.2 --=-=-= Content-Type: text/plain I think this could go to emacs-29. Thanks, Michael. --=-=-=--