From: Po Lu <luangruo@yahoo.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, emacs-devel@gnu.org
Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries
Date: Wed, 31 Jan 2024 14:43:59 +0800 [thread overview]
Message-ID: <87a5omf1e8.fsf@yahoo.com> (raw)
In-Reply-To: <8734ue327d.fsf@gmail.com> ("João Távora"'s message of "Tue, 30 Jan 2024 22:07:18 +0000")
João Távora <joaotavora@gmail.com> writes:
> Seems like this much simpler patch would have done the job. If cl-loop
> is so toxic, even macroexpanding these trivial ones away yields much
> less code and much simpler code. Tests are a welcome addition though.
I did not understand the code using cl-loop, and there are no comments
in this version of the change. For that matter, if there _were_
comments in the original version, I could have understood its intent,
but cryptic cl-lib and pcase labyrinths are all the rage these days.
Anyway, please don't modify log-edit just yet--I plan to modify it to
handle conditional changes and part indicators.
next prev parent reply other threads:[~2024-01-31 6:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org>
[not found] ` <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org>
2024-01-28 13:22 ` master 78fc49407b8 1/3: Improve filling of ChangeLog entries Dmitry Gutov
2024-01-28 13:37 ` Po Lu
2024-01-30 22:07 ` João Távora
2024-01-31 6:43 ` Po Lu [this message]
2024-01-31 10:28 ` João Távora
2024-01-31 11:19 ` Po Lu
2024-01-31 13:22 ` João Távora
2024-01-31 14:01 ` Po Lu
2024-01-31 14:30 ` João Távora
2024-01-31 15:15 ` Dmitry Gutov
2024-01-31 15:32 ` Alan Mackenzie
2024-01-31 16:46 ` João Távora
2024-01-31 18:29 ` Alan Mackenzie
2024-01-31 17:05 ` Dmitry Gutov
2024-01-31 18:45 ` Alan Mackenzie
2024-01-31 20:39 ` Dmitry Gutov
2024-01-29 20:13 ` Stefan Kangas
2024-01-30 1:26 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5omf1e8.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.