From: Po Lu <luangruo@yahoo.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries
Date: Tue, 30 Jan 2024 09:26:20 +0800 [thread overview]
Message-ID: <875xzbharn.fsf@yahoo.com> (raw)
In-Reply-To: <CADwFkm=pN0BgoKFwdzsd-mSKLaVnQ=McJR0D3_ZFCzVZK54e-g@mail.gmail.com> (Stefan Kangas's message of "Mon, 29 Jan 2024 15:13:56 -0500")
Stefan Kangas <stefankangas@gmail.com> writes:
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit 78fc49407b8ef8ec649fe70fcce09101801dbc05
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> Improve filling of ChangeLog entries
>>
>> * lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Rewrite
>> completely.
>> (log-edit-fill-entry): Abandon pcase and cl-lib.
>
> Speaking of commit messages, the above is not at all clear to me.
> More specifically, the word "improve" seems open to interpretation.
>
> Is it just a rewrite to "abandon pcase and cl-lib"? If yes, I think
> that is what should have gone on the first line summary.
>
> If that's not it, what is it that has been improved?
Several bugs causing entries to be improperly filled have been fixed,
and probably countless more I was unaware of; with fill-column set to
44, for example,
* lisp/progmodes/cmake-ts-mode.el
(treesit-induce-sparse-tree)
(treesit-node-child, treesit-node-start)
(cmake-ts-mode--imenu)
(cmake-ts-mode--imenu-1): Remove.
(treesit-search-subtree): Declare.
(cmake-ts-mode--function-name): New
function.
(cmake-ts-mode): Use it.
would have been filled to:
* lisp/progmodes/cmake-ts-mode.el
(treesit-induce-sparse-tree)
(treesit-node-child, treesit-node-start)
(cmake-ts-mode--imenu,
cmake-ts-mode--imenu-1): Remove.
(treesit-search-subtree): Declare.
(cmake-ts-mode--function-name): New
function.
(cmake-ts-mode): Use it.
Not understanding the original code, it was not possible for me to
describe the change in greater detail.
prev parent reply other threads:[~2024-01-30 1:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org>
[not found] ` <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org>
2024-01-28 13:22 ` master 78fc49407b8 1/3: Improve filling of ChangeLog entries Dmitry Gutov
2024-01-28 13:37 ` Po Lu
2024-01-30 22:07 ` João Távora
2024-01-31 6:43 ` Po Lu
2024-01-31 10:28 ` João Távora
2024-01-31 11:19 ` Po Lu
2024-01-31 13:22 ` João Távora
2024-01-31 14:01 ` Po Lu
2024-01-31 14:30 ` João Távora
2024-01-31 15:15 ` Dmitry Gutov
2024-01-31 15:32 ` Alan Mackenzie
2024-01-31 16:46 ` João Távora
2024-01-31 18:29 ` Alan Mackenzie
2024-01-31 17:05 ` Dmitry Gutov
2024-01-31 18:45 ` Alan Mackenzie
2024-01-31 20:39 ` Dmitry Gutov
2024-01-29 20:13 ` Stefan Kangas
2024-01-30 1:26 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xzbharn.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.