From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Wed, 31 Jan 2024 14:43:59 +0800 Message-ID: <87a5omf1e8.fsf@yahoo.com> References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> <540cc339-b7d4-4c1a-b084-c7f739ad4947@gutov.dev> <8734ue327d.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3144"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 07:44:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rV4Kp-0000jQ-BF for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 07:44:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rV4KY-0003QN-JC; Wed, 31 Jan 2024 01:44:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV4KW-0003Q4-0W for emacs-devel@gnu.org; Wed, 31 Jan 2024 01:44:16 -0500 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rV4KU-0008IB-4F for emacs-devel@gnu.org; Wed, 31 Jan 2024 01:44:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706683450; bh=/+WVSCP+4nMEHtG94/HBcLN7Rjs6lakJ50pC0GBSK20=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=to/LjAted6a2OwIg0bEXrJZ9I5bA27fhnk3oR3M5AeMWYZzvQ+K44ewaJH1AWymlXUD9FE/K/xLnwp6fjljuBTsorxpm0d3zwp0sEPmc3aFPv/FDLIS5hogr7RciW73ZLU9etMZvt/kinKmI4YLWw3TZw0KH2GRMG+9NMPffCaKeMK7EBQkv0WEL/9wX8e5pXWcmC6cBH9Dvoyia+iQ09VIrBOZwbvkesqDH/jk0z5B1LbrwH5CDD+Q0+LFVkDi7jzDnzjxrC8bOEJ5m6vtnAG/C/w64eYfMzAbSv40N+GtjtwJfz8CZ1hMom9WHwE89kijqnphtT1/fyIye4vCJcw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706683450; bh=nq3BGsbXddqOmEgEt75+bEqh1BKIS9ydJrltvBy5ljp=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tr68Lca/elddBdphsru6ux+quhq7Qz0lU1TZ/w6ffpUz5+KGnch8sOSlByP6YhXX/E6TVL/B0HENZ8LvKqGXjG6N22gzFDE+hTHxA9s164jgS4WvF2jPCP1dD8ndfaSm1jwMY9YOzRHsssX7UuMVttONorBlj4JnFWeZV3SZeP+04RSR6F5ZgakNZxkQ9SNNPqNOfL0MIgK+DQH+6LtoGldv3se1svwMqQz2ZcLdkbXhkop5WzXva+KJQXMOpWGq3nlhNnVoxpfn95u+Yxh1BE2N9xSzosRmgw9U/aQ5fzSg14jEKIZ/UZ/C3FBR/wwV+hyCRY0CZ+1kzi+OGaF+HQ== X-YMail-OSG: 7HDAqxkVM1mmjaMlxSDz2wHL57YLn1sBh2Gi1GB0mrjR7lG3FAKS7QAvor_qy7C JUz7BGWqgvui899nmBtqA0xkA7Tu3KYWO.2FJGib658.hCJALsu69nLLU9v6Sa.A9COxQrefIrx5 cUW0oILaOZ6yzpho1V2w4OE4uZR8pqpGkmsmCqr1Seg1sYz51vhbn7BNyjXt6G4AEad.yX3O21rR 5VSdDSrM21qSg_Dllicm7B3t.ZOcXtrdCC93WiuCEgTTJGVGtR8fnIwiq4FMtMwBQ7ROxsNZRwUh nW26J.XzpEellIPckbYRf0DxdVSyc7NI1Qz5r6Bi6O4nrteCk2Pa2T3ADs6oXRIwb4ARMrPVANAI 32V7wCBeJdx6jBw_qwSfH_MDgz9aBEUlpY04ODEua_xnsG_LpOliUtMrLSwv6pSmEN01Btu6w7a5 CYPxxEHZgtMktgAVhEMstIYaH4rEFtUrZRcHPoROqqAJ4vtat5pZOgsUI2z9Y8UzESkQ4SapYSSU ymsloXs3fxk4NeDCL7V11RJtl4mA51B6y3qq0YgQj66PKhTg06dzLWIAutloEfknylXySXIWMw7P tLu7B51JhVLW0lRB67B0FpPb72HRgHQiHmlJtt3nxXZQE5yvM_JZWiQl3EwsoCL4TY4Mtyz49aQe 0iVIQerLykctlW7bX0bD14T5rvxyXlULQyiZT_Dy6jX5t96kNwkS1jXKcv0tfht9hw7oQGvAHUNh dvtPJqmolTH9b_vsTd1lm.pTSN3pi_UH5n_uLkjNLvK4M.22MoiQCExvVfibanBQ0QEn.W2ofVny 1Pe0SdLXQ.Angl1RJlL22xLkzomFFybqJpFX5AHIrY X-Sonic-MF: X-Sonic-ID: 581e55f3-6e1a-4d08-bd34-5f2aecec67ba Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Wed, 31 Jan 2024 06:44:10 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-dgkh5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 74b12e424565b4a43cdf8e3d4da38d38; Wed, 31 Jan 2024 06:44:04 +0000 (UTC) In-Reply-To: <8734ue327d.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Tue, 30 Jan 2024 22:07:18 +0000") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.33; envelope-from=luangruo@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315658 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Seems like this much simpler patch would have done the job. If cl-loop > is so toxic, even macroexpanding these trivial ones away yields much > less code and much simpler code. Tests are a welcome addition though. I did not understand the code using cl-loop, and there are no comments in this version of the change. For that matter, if there _were_ comments in the original version, I could have understood its intent, but cryptic cl-lib and pcase labyrinths are all the rage these days. Anyway, please don't modify log-edit just yet--I plan to modify it to handle conditional changes and part indicators.