From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Tue, 30 Jan 2024 09:26:20 +0800 Message-ID: <875xzbharn.fsf@yahoo.com> References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 02:27:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUcu7-0009V7-ML for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 02:27:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUcta-0001gZ-GQ; Mon, 29 Jan 2024 20:26:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUctY-0001gD-PD for emacs-devel@gnu.org; Mon, 29 Jan 2024 20:26:37 -0500 Original-Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUctW-0001T5-D6 for emacs-devel@gnu.org; Mon, 29 Jan 2024 20:26:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706577989; bh=SUau1rNw7KYhB33HFAWKKJTdeyu6trxK3aFz3fXZAMQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=IAIhhSYVN/pzVetzFfIYakOPJwO6O72JWstkzzQlr3ZwHWj6jCSxA2PjjjiLpY6Lkz8O5qUsRr7Qcv8KF8iFZFULdL4C8GmmBZLS9q9EyKLJXF5kvsscXkwbNe8KikPUgbSlDXyVVeZDqLDVSRlt4LqR+ij4Bj0WezZMcvj+4qQ7K8TSpW55Y1bqjdEUHO/4rtMlYe+pv9+fN4DmXB3lay/fsGPZGefS+qAsk21XGKc6y1gSbdfirBHOwos2DIOG22hGiqmgdAp17vPpOkFzdIfqm+ukJ+4gaHJGtAaDCx6cSR3kEPTpAMr0/qr8PuNQccLCFw35/WZ1kmqEgY8E+g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706577989; bh=c8B74TbQSKW9OQeyWTovRFndYXBla0I504hPzxAU/DH=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FVps6YcF/9/SumRzestT/qNbh4vuPd4y2jEZNu+dXBplCMTsLAXQMGOlGbvkiAKrrpTVnntyou3ksLuBeUa9OWEaGaB8D53zgCBlzgYaR2xaNTgtjknNRS41ucm2R3nWSeP90H5nkYQVoM0GOUvW1k1IHDA9mqi+W2TeszGTQTjZCq2i3KlfX4+3nq5DmXzRfjeFjQUpxraeq69EumHv/0O/8Ah0VdGxrIYby/W7svoLaMOSYge4RoKDRV/mux6mDDiMTA0XVIMPPPMjhVcZ6jqi9WqW8LgsFuTvaA0CWuevXe+zrdW++hvN5Gpv3+CudMUR16Ohl+32oy3X9U2Mvg== X-YMail-OSG: BZM1w.kVM1kxqs2.zOirqxjlLj8suWu33GEDxZyeYFx_EKiDjBVhgEU8iEVVm2. sXIIXsYuvhotzvUV9J_NSv2VtU7fNw3mACKeqJMXOW9ownknhIHf4IPQquq3DzrDZmOzhxPW5lpn dm1fUT6ubk0JOaFNEMoVBkvM4HJpH6iB2Z.UZG_HShau2Br47GA_WfjGHk8zFj6xHC0.qgf7i8ex wBBM3HMnrvHuhrKSB50i4E_YytOAfKMMCuMbr_X_GrV5TvzT8wOZL0jC9LnxPqHjvKcZ.ry5XBNy ALcX12XvFeAy3x5lgczwrD3y.Klxo6j5t8z1qIowWpyhfnbmvc7FELdkGN2c0DkOcj.KfIPzSm4d P3gfTG1JJDC.Db0aP1tLN8QRJhKDAxWFD2P_V8HJFO26nM1cv10AGmBclFglawZR0H5.lti_Xqc3 OGYY32vXVjKey.NAMRdMFihAQBARff5IyO1OE_KbnG1V3G7d_OPgafAQIO2AGD70X_TQ7MaNM_pe M9NuROAUZukUmB428CwdvCFAMCaHH7aETACgjoOLqeg_xg1zfCz57KsVx8QRARAyFNHKXwHSqhtT uWXurK8HDsrlQGpG97kpjDphU5NtLC.096VaIH0yJgfMzDW2IaUxnYzzUTfvKPo3AsyixIXQ5Jbj UuroquJ2YwUINJLiGVJ4hOLAYxLTouLu3XE3bxf1yRW8kW8Ep3jU5Ao4JLOjDco9HO2H09vF8vOe 5d4.KTRzz7gOOTrUOQgPikMVF71.SKXOYCAJ2DhtllZfQ4htByIcL8fsRk3uFlht3khOCI_E1JCN WV5AGdw9L9Qiz1oTyomCJvKc5SjGpVpaOFk.KNcNUz X-Sonic-MF: X-Sonic-ID: 47a66913-b67e-4baf-8c37-ed93cea14cd4 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Tue, 30 Jan 2024 01:26:29 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-cp2ns (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6fbf2b6d46747f21c1d20db5507fff48; Tue, 30 Jan 2024 01:26:25 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Mon, 29 Jan 2024 15:13:56 -0500") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.146; envelope-from=luangruo@yahoo.com; helo=sonic302-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315615 Archived-At: Stefan Kangas writes: > Po Lu via Mailing list for Emacs changes writes: > >> branch: master >> commit 78fc49407b8ef8ec649fe70fcce09101801dbc05 >> Author: Po Lu >> Commit: Po Lu >> >> Improve filling of ChangeLog entries >> >> * lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Rewrite >> completely. >> (log-edit-fill-entry): Abandon pcase and cl-lib. > > Speaking of commit messages, the above is not at all clear to me. > More specifically, the word "improve" seems open to interpretation. > > Is it just a rewrite to "abandon pcase and cl-lib"? If yes, I think > that is what should have gone on the first line summary. > > If that's not it, what is it that has been improved? Several bugs causing entries to be improperly filled have been fixed, and probably countless more I was unaware of; with fill-column set to 44, for example, * lisp/progmodes/cmake-ts-mode.el (treesit-induce-sparse-tree) (treesit-node-child, treesit-node-start) (cmake-ts-mode--imenu) (cmake-ts-mode--imenu-1): Remove. (treesit-search-subtree): Declare. (cmake-ts-mode--function-name): New function. (cmake-ts-mode): Use it. would have been filled to: * lisp/progmodes/cmake-ts-mode.el (treesit-induce-sparse-tree) (treesit-node-child, treesit-node-start) (cmake-ts-mode--imenu, cmake-ts-mode--imenu-1): Remove. (treesit-search-subtree): Declare. (cmake-ts-mode--function-name): New function. (cmake-ts-mode): Use it. Not understanding the original code, it was not possible for me to describe the change in greater detail.