From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Date: Sat, 21 Jan 2023 17:35:16 +0200 Message-ID: <83h6wjlx3f.fsf@gnu.org> References: <87pmbmnvdd.fsf@web.de> <87358iuqsj.fsf@web.de> <87edro6jl7.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3807"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59559@debbugs.gnu.org, drew.adams@oracle.com To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 16:36:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJFuh-0000oR-C7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 16:36:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJFuX-00022W-CD; Sat, 21 Jan 2023 10:36:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFuU-00022N-Gu for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 10:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJFuU-0003t2-4P for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 10:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJFuT-0004Lh-TP for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 10:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59559 X-GNU-PR-Package: emacs Original-Received: via spool by 59559-submit@debbugs.gnu.org id=B59559.167431532416661 (code B ref 59559); Sat, 21 Jan 2023 15:36:01 +0000 Original-Received: (at 59559) by debbugs.gnu.org; 21 Jan 2023 15:35:24 +0000 Original-Received: from localhost ([127.0.0.1]:49537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFts-0004Kd-4r for submit@debbugs.gnu.org; Sat, 21 Jan 2023 10:35:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJFtq-0004KP-7V for 59559@debbugs.gnu.org; Sat, 21 Jan 2023 10:35:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFti-0002mb-0C; Sat, 21 Jan 2023 10:35:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Lh42rOAdgvmPV8dIDlETkgkFHU5+NrvfsRE1o8f2kZg=; b=Hmk/3Hqd02d8 OsAFMUjhZSZJdwvmX7kCpvqgRu7ctqfq496oXFOTjlbxmXnb2sztgK2UNGmdlimxHrwXvBOn8e5Lg MLx8YgsfI8x8Axyf4fyyIATSDvKcSVcNTyQX3adGinLXsoApu/AQrQdZ5GnP9DHv258XmXKs2lh9Z Wh+W2XFYthWfRnIyK7xyRdPxKZBH0TTm1rfWaXWbKCuIPOVsrUEY/51u9VEYZKZUYA9/0gCT8yxM7 P3+N5MgYTmLurJIjWosCZJ6/yB3vbYBes9r4U0qlw7tfdfNKUZ+OfSfhivE37OYGjg5nGo/hWV0ig BlTsy2HTiVETzRJQ3hJ7DQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJFtg-0001iz-PV; Sat, 21 Jan 2023 10:35:13 -0500 In-Reply-To: <87edro6jl7.fsf@web.de> (message from Michael Heerdegen on Sat, 21 Jan 2023 15:36:04 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253871 Archived-At: > Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org> > From: Michael Heerdegen > Date: Sat, 21 Jan 2023 15:36:04 +0100 > > (defmacro minibuffer-with-setup-hook (fun &rest body) > "Temporarily add FUN to `minibuffer-setup-hook' while executing BODY. > > -By default, FUN is prepended to `minibuffer-setup-hook'. But if FUN is of > -the form `(:append FUN1)', FUN1 will be appended to `minibuffer-setup-hook' > -instead of prepending it. > +In the default case, FUN is an expression that should evaluate to > +a function, and the result will be prepended to > +`minibuffer-setup-hook'. If FUN is an unquoted list of the > +form `(:append FUN1)', the result of evaluating FUN1 will be > +appended to `minibuffer-setup-hook' instead of prepending it. How about just adding the obvious to the first sentence: Temporarily add function FUN to `minibuffer-setup-hook' while executing BODY. All the rest sounds clear to me, and I find the original text less confusing than your proposed change ("expression that should evaluate to a function"?).