unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: case-insensitive string comparison
Date: Tue, 26 Jul 2022 10:16:08 -0400	[thread overview]
Message-ID: <lzpmhs0xjr.fsf@3c22fb11fdab.ant.amazon.com> (raw)
In-Reply-To: <83lesgc9ch.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jul 2022 16:05:50 +0300")

> * Eli Zaretskii <ryvm@tah.bet> [2022-07-26 16:05:50 +0300]:
>
>> From: Sam Steingold <sds@gnu.org>
>> Date: Mon, 25 Jul 2022 15:39:34 -0400
>> 
>> > * Eli Zaretskii <ryvm@tah.bet> [2022-07-25 18:58:19 +0300]:
>> >
>> >> > (string-collate-equalp "a" "A" current-locale-environment t)
>> >> > ==> nil
>> >> > current-locale-environment
>> >> > ==> "en_US.UTF-8"
>> >
>> > I cannot reproduce this:
>> >
>> >   (string-collate-equalp "a" "A" current-locale-environment t)
>> >     => t
>> >   current-locale-environment
>> >     => "en_US.UTF-8"
>> >
>> > What OS is this, and which Emacs version?
>> 
>> GNU Emacs 29.0.50 (build 5, x86_64-apple-darwin21.5.0, NS appkit-2113.50 Version 12.4 (Build 21F79))
>>  of 2022-07-25
>> Repository revision: ffe12ff2503917e47c0356195b31430996c148f9
>> Repository branch: master
>> Windowing system distributor 'Apple', version 10.3.2113
>> System Description:  macOS 12.4
>
> Could be something macOS-specific.  Maybe your system doesn't define
> the __STDC_ISO_10646__ feature?  In that case, string-collate-equalp
> (see the doc string) behaves like string-equal, and that one doesn't
> have a case-insensitive variant.

How do I find out?
--8<---------------cut here---------------start------------->8---
echo  > .zzz.c;
gcc -E -dM .zzz.c | grep __STDC_ISO_10646__
--8<---------------cut here---------------end--------------->8---
does not print anything, but maybe I need to `#include' something?

> In general, locale-specific comparison is a bad idea in Emacs...
> For that reason, I suggest always using compare-strings instead.

Thank you very much for the clear and detailed explanation!

>> >> It is okay to add a `string-equal-ignore-case' based on `compare-strings'?
>> >> (even though it does not recognize "SS" and "ß" as equal)
>> >
>> > What's wrong with calling compare-strings directly?
>>
>> I want to be able to use `string-equal-ignore-case' as a :test argument
>> to things like `cl-find'.
>
> Then write a thin wrapper around compare-strings, and be done.

I think the need is sufficiently generic, e.g., BBDB provides such a
wrapper, as, I am sure, do many other packages.
Many core files can be simplified by using `string-equal-ignore-case'
(just like with the `string-prefix-p').

Thank again!

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://www.dhimmitude.org https://thereligionofpeace.com
When you are arguing with an idiot, your opponent is doing the same.



  reply	other threads:[~2022-07-26 14:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 17:27 case-insensitive string comparison Sam Steingold
2022-07-19 18:06 ` Mattias Engdegård
2022-07-19 18:56   ` Sam Steingold
2022-07-20  4:39     ` tomas
2022-07-20 11:35       ` Eli Zaretskii
2022-07-20 13:30         ` tomas
2022-07-19 18:16 ` Stefan Kangas
2022-07-19 19:39 ` Roland Winkler
2022-07-19 22:47   ` Sam Steingold
2022-07-20  2:21     ` Roland Winkler
2022-07-20  3:01     ` Stefan Monnier
2022-07-20 16:22       ` Sam Steingold
2022-07-25 14:23         ` Sam Steingold
2022-07-25 15:58           ` Eli Zaretskii
2022-07-25 19:39             ` Sam Steingold
2022-07-26 13:05               ` Eli Zaretskii
2022-07-26 14:16                 ` Sam Steingold [this message]
2022-07-26 15:53                   ` Eli Zaretskii
2022-07-26 16:00                     ` Sam Steingold
2022-07-26 16:16                     ` Lars Ingebrigtsen
2022-07-26 14:43                 ` Robert Pluim
2022-07-25 19:37           ` Bruno Haible
2022-07-26  3:24           ` Richard Stallman
2022-07-26  8:00             ` Helmut Eller
2022-07-26 12:21               ` Eli Zaretskii
2022-07-27  2:58               ` Richard Stallman
2022-07-31  8:24                 ` Eli Zaretskii
2022-07-26 14:28             ` Sam Steingold
2022-07-26 15:42               ` Sam Steingold
2022-07-26 16:10               ` Eli Zaretskii
2022-07-26 18:56                 ` Bruno Haible
2022-07-26 19:30                   ` Eli Zaretskii
2022-07-20 16:24       ` Roland Winkler
2022-07-20 17:06         ` Sam Steingold
2022-07-20 17:16           ` Eli Zaretskii
2022-07-20 17:12         ` Eli Zaretskii
2022-07-20 17:37           ` Roland Winkler
2022-07-20 17:50             ` Eli Zaretskii
2022-07-20 18:10               ` Roland Winkler
2022-07-20 18:16                 ` Eli Zaretskii
2022-07-20 18:18                   ` [External] : " Drew Adams
2022-07-21  6:56                   ` Eli Zaretskii
2022-07-21 14:19                     ` Roland Winkler
2022-07-21 15:53                       ` Eli Zaretskii
2022-07-21 16:35                         ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzpmhs0xjr.fsf@3c22fb11fdab.ant.amazon.com \
    --to=sds@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).