unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org, Roland Winkler <winkler@gnu.org>
Subject: Re: case-insensitive string comparison
Date: Tue, 19 Jul 2022 18:47:14 -0400	[thread overview]
Message-ID: <lzmtd4u3d9.fsf@3c22fb11fdab.ant.amazon.com> (raw)
In-Reply-To: <87ilnsq4cr.fsf@gnu.org> (Roland Winkler's message of "Tue, 19 Jul 2022 14:39:32 -0500")

> * Roland Winkler <jvaxyre@tah.bet> [2022-07-19 14:39:32 -0500]:
>
> On Tue, Jul 19 2022, Sam Steingold wrote:
>> Specifically, I would like to add
>>
>> (defun string-equal-ignore-case (s1 s2)
>>   "Like `string-equal', but case-insensitive.
>> Upper-case and lower-case letters are treated as equal.
>> Unibyte strings are converted to multibyte for comparison."
>>   (eq t (compare-strings s1 0 nil s2 0 nil t)))
>>
>> to subr.el next to `string-prefix-p' - is this okay?
>
> I have run into this problem fairly often that I needed case-insensitive
> string comparison, and I believe various elisp packages include a
> "private" version of the above.  I always felt that
> `(eq t (compare-strings s1 0 nil s2 0 nil t))' was a crutch for this
> common problem.  Would it make sense to give the built-in function
> string-equal an optional arg ignore-case?

No, because I need to be able to pass `string-equal-ignore-case' to
things like `cl-find' as `:test' &c.

Also, if you look at fns.c, `string-equal' is basically `memcmp', while
`compare-strings' is way more complex.

PS. Actually, compare-strings/ignore_case is broken because it does,
essentially, upcase both arguments, see https://stackoverflow.com/q/319426/850781


-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.2113
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://memri.org https://www.dhimmitude.org http://think-israel.org
A poet who reads his verse in public may have other nasty habits.



  reply	other threads:[~2022-07-19 22:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 17:27 case-insensitive string comparison Sam Steingold
2022-07-19 18:06 ` Mattias Engdegård
2022-07-19 18:56   ` Sam Steingold
2022-07-20  4:39     ` tomas
2022-07-20 11:35       ` Eli Zaretskii
2022-07-20 13:30         ` tomas
2022-07-19 18:16 ` Stefan Kangas
2022-07-19 19:39 ` Roland Winkler
2022-07-19 22:47   ` Sam Steingold [this message]
2022-07-20  2:21     ` Roland Winkler
2022-07-20  3:01     ` Stefan Monnier
2022-07-20 16:22       ` Sam Steingold
2022-07-25 14:23         ` Sam Steingold
2022-07-25 15:58           ` Eli Zaretskii
2022-07-25 19:39             ` Sam Steingold
2022-07-26 13:05               ` Eli Zaretskii
2022-07-26 14:16                 ` Sam Steingold
2022-07-26 15:53                   ` Eli Zaretskii
2022-07-26 16:00                     ` Sam Steingold
2022-07-26 16:16                     ` Lars Ingebrigtsen
2022-07-26 14:43                 ` Robert Pluim
2022-07-25 19:37           ` Bruno Haible
2022-07-26  3:24           ` Richard Stallman
2022-07-26  8:00             ` Helmut Eller
2022-07-26 12:21               ` Eli Zaretskii
2022-07-27  2:58               ` Richard Stallman
2022-07-31  8:24                 ` Eli Zaretskii
2022-07-26 14:28             ` Sam Steingold
2022-07-26 15:42               ` Sam Steingold
2022-07-26 16:10               ` Eli Zaretskii
2022-07-26 18:56                 ` Bruno Haible
2022-07-26 19:30                   ` Eli Zaretskii
2022-07-20 16:24       ` Roland Winkler
2022-07-20 17:06         ` Sam Steingold
2022-07-20 17:16           ` Eli Zaretskii
2022-07-20 17:12         ` Eli Zaretskii
2022-07-20 17:37           ` Roland Winkler
2022-07-20 17:50             ` Eli Zaretskii
2022-07-20 18:10               ` Roland Winkler
2022-07-20 18:16                 ` Eli Zaretskii
2022-07-20 18:18                   ` [External] : " Drew Adams
2022-07-21  6:56                   ` Eli Zaretskii
2022-07-21 14:19                     ` Roland Winkler
2022-07-21 15:53                       ` Eli Zaretskii
2022-07-21 16:35                         ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lzmtd4u3d9.fsf@3c22fb11fdab.ant.amazon.com \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).