Re: [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29

Re: [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29

[Stefan Monnier]

> @@ -149,10 +149,16 @@ This uses the variable meow-update-cursor-functions-alist, finds the first
>  item in which the car evaluates to true, and runs the cdr. The last item's car
>  in the list will always evaluate to true."
>    (with-current-buffer (window-buffer)
> -    (thread-last meow-update-cursor-functions-alist
> -      (cl-remove-if-not (lambda (el) (funcall (car el))))
> -      (cdar)
> -      (funcall))))
> +    ;; Adapt Emacs29
> +    ;; Using thread-last here causes following error:
> +    ;; Warning: Optimization failure for cdar: Handler: internal--compiler-macro-cXXr (wrong-number-of-arguments (2 . 2) 1)
> +    ;; Original code:
> +    ;; (thread-last meow-update-cursor-functions-alist
> +    ;;   (cl-remove-if-not (lambda (el) (funcall (car el))))
> +    ;;   (cdar)
> +    ;;   (funcall))
> +    (funcall (cdar (cl-remove-if-not (lambda (el) (funcall (car el)))
> +                                     meow-update-cursor-functions-alist)))))

My crystal ball suggests this optimization failure is a red-herring and
that the real problem is that you don't `(require 'subr-x)` so
`thread-last` is not defined and the call to `thread-last` is compiled
as if it were a function call rather than a macro call.


        Stefan

Re: [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29

[Stefan Monnier]

> My crystal ball suggests this optimization failure is a red-herring and
> that the real problem is that you don't `(require 'subr-x)` so
> `thread-last` is not defined and the call to `thread-last` is compiled
> as if it were a function call rather than a macro call.

Hmm... once again I should have waitied to read all my mail before
sending this, since the fix was installed soon after (hence before
I sent that email).

Sorry 'bout that.
I guess the only upside is that my crystal ball was right :-)


        Stefan