unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: team-race <race.game.team@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29
Date: Mon, 27 Mar 2023 15:23:48 -0400	[thread overview]
Message-ID: <jwvedpa3srn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20230327050035.75915C0060F@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 27 Mar 2023 01:00:35 -0400 (EDT)")

> @@ -149,10 +149,16 @@ This uses the variable meow-update-cursor-functions-alist, finds the first
>  item in which the car evaluates to true, and runs the cdr. The last item's car
>  in the list will always evaluate to true."
>    (with-current-buffer (window-buffer)
> -    (thread-last meow-update-cursor-functions-alist
> -      (cl-remove-if-not (lambda (el) (funcall (car el))))
> -      (cdar)
> -      (funcall))))
> +    ;; Adapt Emacs29
> +    ;; Using thread-last here causes following error:
> +    ;; Warning: Optimization failure for cdar: Handler: internal--compiler-macro-cXXr (wrong-number-of-arguments (2 . 2) 1)
> +    ;; Original code:
> +    ;; (thread-last meow-update-cursor-functions-alist
> +    ;;   (cl-remove-if-not (lambda (el) (funcall (car el))))
> +    ;;   (cdar)
> +    ;;   (funcall))
> +    (funcall (cdar (cl-remove-if-not (lambda (el) (funcall (car el)))
> +                                     meow-update-cursor-functions-alist)))))

My crystal ball suggests this optimization failure is a red-herring and
that the real problem is that you don't `(require 'subr-x)` so
`thread-last` is not defined and the call to `thread-last` is compiled
as if it were a function call rather than a macro call.


        Stefan




       reply	other threads:[~2023-03-27 19:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167989323517.3717.16516832099659022451@vcs2.savannah.gnu.org>
     [not found] ` <20230327050035.75915C0060F@vcs2.savannah.gnu.org>
2023-03-27 19:23   ` Stefan Monnier [this message]
2023-03-27 19:38     ` [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29 Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvedpa3srn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=race.game.team@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).