From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/meow cee4a34917: Fix a compilation warning in Emacs29 Date: Mon, 27 Mar 2023 15:23:48 -0400 Message-ID: References: <167989323517.3717.16516832099659022451@vcs2.savannah.gnu.org> <20230327050035.75915C0060F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: team-race Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 27 21:24:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgsSa-0001vr-IU for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Mar 2023 21:24:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgsRi-0007Tn-61; Mon, 27 Mar 2023 15:23:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgsRg-0007TG-T1 for emacs-devel@gnu.org; Mon, 27 Mar 2023 15:23:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgsRf-0003kM-AP for emacs-devel@gnu.org; Mon, 27 Mar 2023 15:23:56 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0B50880D0F; Mon, 27 Mar 2023 15:23:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1EECB80355; Mon, 27 Mar 2023 15:23:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679945030; bh=388OR4H6X4upkP5Pe7fvZH+MOh1T0zDUaQV+PZMLJAc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GTKYKzNU8q4LHOnsyCl3Fv7mNAjJBvY6mCcuMweuQ0DySPNOnjKl2pDEj1+zbqWl/ fIIrCdna1pAg+2N84mJt0qD/funY8ghHTGxM9sdYDMZG0jnyOc7DiFMX341rVtyXZp AbREwBBGWHVO5Q5pR6JeYLQxPniOv6sWkQt1s8qM99uo0CWLTja38T7cui12edoBmG sx3/iZEwoL4xLDu2wG3PBaqrI8QthwwW4Z2h2YNrEqX/GHZXcUL8khnUXB5QgiomA1 VrYCFHmYmiaR0U+MbDxDUGgbFk+r8bpmB7ph19s+yvXMB3G1myTBz0+7/0L/RhA2Uw BetEzESlIQVsw== Original-Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AA64E1232D0; Mon, 27 Mar 2023 15:23:49 -0400 (EDT) In-Reply-To: <20230327050035.75915C0060F@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 27 Mar 2023 01:00:35 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304788 Archived-At: > @@ -149,10 +149,16 @@ This uses the variable meow-update-cursor-functions-alist, finds the first > item in which the car evaluates to true, and runs the cdr. The last item's car > in the list will always evaluate to true." > (with-current-buffer (window-buffer) > - (thread-last meow-update-cursor-functions-alist > - (cl-remove-if-not (lambda (el) (funcall (car el)))) > - (cdar) > - (funcall)))) > + ;; Adapt Emacs29 > + ;; Using thread-last here causes following error: > + ;; Warning: Optimization failure for cdar: Handler: internal--compiler-macro-cXXr (wrong-number-of-arguments (2 . 2) 1) > + ;; Original code: > + ;; (thread-last meow-update-cursor-functions-alist > + ;; (cl-remove-if-not (lambda (el) (funcall (car el)))) > + ;; (cdar) > + ;; (funcall)) > + (funcall (cdar (cl-remove-if-not (lambda (el) (funcall (car el))) > + meow-update-cursor-functions-alist))))) My crystal ball suggests this optimization failure is a red-herring and that the real problem is that you don't `(require 'subr-x)` so `thread-last` is not defined and the call to `thread-last` is compiled as if it were a function call rather than a macro call. Stefan