From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
Date: Wed, 21 Aug 2013 16:08:40 -0400 [thread overview]
Message-ID: <jwvmwoaerqo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yqpgvc2z8jgh.fsf@gmx.de> (Michael Albinus's message of "Wed, 21 Aug 2013 11:46:38 +0200")
>> My point is simply that the backtrace you show does not seem to perform
>> non-essential work, so binding non-essential is not right. It is
>> computing the completion of /ssh:vagrant@192.168.10.2:/ (not quite sure
>> why, since the backtrace doesn't go further up).
> The whole backtrace is in
> <http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00533.html>
> (the second backtrace in this message).
So we're in the middle of minibuffer--complete-and-exit which calls
try-completion. That's very definitely not "non-essential".
>> At the same time I wonder why (substitute-in-file-name
>> "/ssh:vagrant@192.168.10.") should signal an error: it looks like an
>> incomplete filename, so we don't know yet whether it'll really be an
>> error or not.
> For Tramp, it is a complete filename wrt syntax. "ssh" is recognised as
> host name, which is regarded as an error since we had decided this some
> weeks ago. See <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13900#24>.
Yes, it could be a "complete but ambiguous/erroneous" file name, but it
could also be a "not yet complete file name". So maybe, if there's no
":" nor "/" after "/ssh:", we should refrain from signaling an error.
> Setting `non-essential' to t is a mean to tell Tramp not to check this.
I do know that, but that's just an ugly hack here, since the code is not
non-essential.
Stefan
next prev parent reply other threads:[~2013-08-21 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VBinS-0002iC-21@vcs.savannah.gnu.org>
2013-08-20 14:35 ` [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential' Stefan Monnier
2013-08-20 14:59 ` Michael Albinus
2013-08-20 20:35 ` Stefan Monnier
2013-08-21 9:46 ` Michael Albinus
2013-08-21 20:08 ` Stefan Monnier [this message]
2013-08-22 9:50 ` Michael Albinus
2013-08-22 15:39 ` Stefan Monnier
2013-08-22 18:40 ` Michael Albinus
2013-08-23 3:21 ` Stefan Monnier
2013-08-26 13:19 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwoaerqo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).