unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
Date: Tue, 20 Aug 2013 10:35:54 -0400	[thread overview]
Message-ID: <jwv7gfgph0j.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1VBinS-0002iC-21@vcs.savannah.gnu.org> (Michael Albinus's message of "Tue, 20 Aug 2013 10:04:18 +0000")

>   * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
  
This is wrong.  completion--sifn-requote is used in many contexts, some
of which are "essential" and some not.  IOW if you need to bind
non-essential, it shouldn't be here, but somewhere higher up the
call-chain.


        Stefan



       reply	other threads:[~2013-08-20 14:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VBinS-0002iC-21@vcs.savannah.gnu.org>
2013-08-20 14:35 ` Stefan Monnier [this message]
2013-08-20 14:59   ` [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential' Michael Albinus
2013-08-20 20:35     ` Stefan Monnier
2013-08-21  9:46       ` Michael Albinus
2013-08-21 20:08         ` Stefan Monnier
2013-08-22  9:50           ` Michael Albinus
2013-08-22 15:39             ` Stefan Monnier
2013-08-22 18:40               ` Michael Albinus
2013-08-23  3:21                 ` Stefan Monnier
2013-08-26 13:19                   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7gfgph0j.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).