From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'. Date: Wed, 21 Aug 2013 16:08:40 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377115884 6850 80.91.229.3 (21 Aug 2013 20:11:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Aug 2013 20:11:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 21 22:11:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VCEkW-0002BC-Ix for ged-emacs-devel@m.gmane.org; Wed, 21 Aug 2013 22:11:24 +0200 Original-Received: from localhost ([::1]:56573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCEkW-0007BA-45 for ged-emacs-devel@m.gmane.org; Wed, 21 Aug 2013 16:11:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCEhz-0005A5-58 for emacs-devel@gnu.org; Wed, 21 Aug 2013 16:08:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCEht-00080Q-B1 for emacs-devel@gnu.org; Wed, 21 Aug 2013 16:08:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:65392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCEht-0007zj-67 for emacs-devel@gnu.org; Wed, 21 Aug 2013 16:08:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEvw4Xc4IeAQEBAQIBAQJTIwULCzQSFBQEDSQTiAsCBAzBIZEKA5Nfg0qNUYFegxM X-IPAS-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEvw4Xc4IeAQEBAQIBAQJTIwULCzQSFBQEDSQTiAsCBAzBIZEKA5Nfg0qNUYFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="22829305" Original-Received: from 206-248-179-83.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Aug 2013 16:08:33 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 22EEF66DC1; Wed, 21 Aug 2013 16:08:40 -0400 (EDT) In-Reply-To: (Michael Albinus's message of "Wed, 21 Aug 2013 11:46:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162957 Archived-At: >> My point is simply that the backtrace you show does not seem to perform >> non-essential work, so binding non-essential is not right. It is >> computing the completion of /ssh:vagrant@192.168.10.2:/ (not quite sure >> why, since the backtrace doesn't go further up). > The whole backtrace is in > > (the second backtrace in this message). So we're in the middle of minibuffer--complete-and-exit which calls try-completion. That's very definitely not "non-essential". >> At the same time I wonder why (substitute-in-file-name >> "/ssh:vagrant@192.168.10.") should signal an error: it looks like an >> incomplete filename, so we don't know yet whether it'll really be an >> error or not. > For Tramp, it is a complete filename wrt syntax. "ssh" is recognised as > host name, which is regarded as an error since we had decided this some > weeks ago. See . Yes, it could be a "complete but ambiguous/erroneous" file name, but it could also be a "not yet complete file name". So maybe, if there's no ":" nor "/" after "/ssh:", we should refrain from signaling an error. > Setting `non-essential' to t is a mean to tell Tramp not to check this. I do know that, but that's just an ugly hack here, since the code is not non-essential. Stefan