From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
Date: Thu, 22 Aug 2013 11:39:24 -0400 [thread overview]
Message-ID: <jwvob8pd9uo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yqpgr4dmkqa1.fsf@gmx.de> (Michael Albinus's message of "Thu, 22 Aug 2013 11:50:46 +0200")
>> So we're in the middle of minibuffer--complete-and-exit which calls
>> try-completion. That's very definitely not "non-essential".
> Not `minibuffer--complete-and-exit'. But the completion functions I
> would call non-essential.
Huh? You did notice that the command's name has "-complete-" in it, right?
> As said, I don't know too much about completion code in minibuffer.el
> (and the functions' docstrings don't help much). Maybe
> `completion--sifn-requote' is not suited to bind `non-essential'. But
> there are other `completion--*' functions in the backtrace, up to
> `minibuffer--complete-and-exit'.
They're all just computing the completion.
>> Yes, it could be a "complete but ambiguous/erroneous" file name, but it
>> could also be a "not yet complete file name". So maybe, if there's no
>> ":" nor "/" after "/ssh:", we should refrain from signaling an error.
> Hmm. Why not signalling a pilot error, when a user applies "C-x
> f /sudo: RET"? It's not so different from the case the user has
> described in Bug#13900, which was the trigger to introduce the rule
> "host name != any method name".
Then how about a different take on the problem: Tramp shouldn't signal
an "ambiguous file name" error when its behavior would be the same
either way. AFAIK substitute-in-file-name would return the same result
regardless of whether "/ssh:vagrant@192.168.10." is taken to be the file
"vagrant@192.168.10." in host "ssh" or access via ssh to host
"192.168.10.".
> I don't know which further plans you have with `non-essential'. But its
> setting to t is acknowledged so far only in ange-ftp and Tramp.
So far.
> And it is bound to t only in icomplete.el, ido.el and rfn-eshadow.el, as
> yet. For exactly that reason: "please relax your tests and connection
> actions when performing file name completion or minibuffer decoration".
The key word is "decoration" and not "completion". The present case is
about completion and not about decoration.
> That doesn't sound ugly to me.
It's called `non-essential' and not `tramp-inhibit' specifically because
I don't want icomplete.el and friends to have Tramp-specific hacks
in them. If you start abusing it on the premise that "that's how I use
it in Tramp", then it defeats the whole purpose.
Stefan
next prev parent reply other threads:[~2013-08-22 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VBinS-0002iC-21@vcs.savannah.gnu.org>
2013-08-20 14:35 ` [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential' Stefan Monnier
2013-08-20 14:59 ` Michael Albinus
2013-08-20 20:35 ` Stefan Monnier
2013-08-21 9:46 ` Michael Albinus
2013-08-21 20:08 ` Stefan Monnier
2013-08-22 9:50 ` Michael Albinus
2013-08-22 15:39 ` Stefan Monnier [this message]
2013-08-22 18:40 ` Michael Albinus
2013-08-23 3:21 ` Stefan Monnier
2013-08-26 13:19 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob8pd9uo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).