Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'.

[Michael Albinus <michael.albinus@gmx.de>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>   * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
>   
> This is wrong.  completion--sifn-requote is used in many contexts, some
> of which are "essential" and some not.  IOW if you need to bind
> non-essential, it shouldn't be here, but somewhere higher up the
> call-chain.

Honestly, I don't know too much about the completion code in
minibuffer.el. The OP has reported the following backtrace (shortened by
me):

      substitute-in-file-name("/ssh:vagrant@192.168.10.")
      completion--sifn-requote(27 "/ssh:vagrant@192.168.10.2:/")
      completion--twq-try("/ssh:vagrant@192.168.10.2:/" "/ssh:vagrant@192.168.10.2:/" "/ssh:vagrant@192.168.10.2:/" 0 substitute-in-file-name completion--sifn-requote)
      completion--file-name-table("/ssh:vagrant@192.168.10.2:/" file-exists-p nil)
      complete-with-action(nil completion--file-name-table "/ssh:vagrant@192.168.10.2:/" file-exists-p)
      #[257 "\303\302\300\301$\207" ["/ssh:vagrant@192.168.10.2:/" file-exists-p nil complete-with-action] 6 "\n\n(fn TABLE)"](completion--file-name-table)
      funcall(#[257 "\303\302\300\301$\207" ["/ssh:vagrant@192.168.10.2:/" file-exists-p nil complete-with-action] 6 "\n\n(fn TABLE)"] completion--file-name-table)
      (setq res (funcall fun (car (prog1 xs (setq xs (cdr xs))))))
      (condition-case err (setq res (funcall fun (car (prog1 xs (setq xs (cdr xs)))))) (error (if firsterror nil (setq firsterror err)) nil))
      (while (and (not res) xs) (condition-case err (setq res (funcall fun (car (prog1 xs (setq xs (cdr xs)))))) (error (if firsterror nil (setq firsterror err)) nil)))
      (let ((firsterror nil) res) (while (and (not res) xs) (condition-case err (setq res (funcall fun (car (prog1 xs (setq xs ...))))) (error (if firsterror nil (setq firsterror err)) nil))) (or res (if firsterror (signal (car firsterror) (cdr firsterror)))))
      completion--some(#[257 "\303\302\300\301$\207" ["/ssh:vagrant@192.168.10.2:/" file-exists-p nil complete-with-action] 6 "\n\n(fn TABLE)"] (completion--embedded-envvar-table completion--file-name-table))
      read-file-name-internal("/ssh:vagrant@192.168.10.2:/" file-exists-p nil)
      try-completion("/ssh:vagrant@192.168.10.2:/" read-file-name-internal file-exists-p)

Sadly, I cannot reproduce this scenario locally. And I have no idea, why

      completion--sifn-requote(27 "/ssh:vagrant@192.168.10.2:/")

calls

      substitute-in-file-name("/ssh:vagrant@192.168.10.")

>         Stefan

Best regards, Michael.