unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Clive Tovero <clive.tovero@aol.com>
Cc: emacs-devel@gnu.org
Subject: Re: Okay to commit purely cosmetic (indendation) fixes?
Date: Mon, 10 Aug 2020 11:39:10 -0400	[thread overview]
Message-ID: <bfbb47cf-2185-b1d9-71d6-0ecb80735723@aol.com> (raw)
In-Reply-To: <83wo264mwo.fsf@gnu.org>

>> Whitespace changes make following code changes more difficult when
>> digging into the history.
> 
> Yes.  They make whole lines look like due to someone who only changed
> the whitespace.

Thank you, I had heard the recommendation to not make whitespace-only 
commits, I didn't understand why.  I guess I would have to know what 
tools you are using and what task you are doing to completely 
understand--many diff tools are capable of ignoring whitespace changes 
and highlighting whitespace.  If you are looking at raw diff or 
something, I guess that would be a problem.

> 
>>> By the way, could you point us to the coding standard for Emacs that
>>> would would give us guidance?
>>
>> Nope.  Perhaps somebody else can?
> 
> I might, but I don't think I understand what coding standards are
> being sought here, and in which programming language.
> 

My use of "coding standard" was a poor choice of words, I'm sorry for 
that.  I meant documentation of your software development process, 
including issues like this, a "Commiter's Guide" e.g.  Then you could 
tell them please RTFM, and not lead to discussions like this.



  reply	other threads:[~2020-08-10 15:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com>
2020-08-09 22:40 ` Okay to commit purely cosmetic (indendation) fixes? Clive Tovero
2020-08-10 10:53   ` Lars Ingebrigtsen
2020-08-10 12:23     ` Stefan Monnier
2020-08-10 16:20       ` Karl Fogel
2020-08-10 14:04     ` Eli Zaretskii
2020-08-10 15:39       ` Clive Tovero [this message]
2020-08-10 15:51         ` Eli Zaretskii
2020-08-10 17:55           ` Clive Tovero
     [not found] <e0dab5e9-5603-b2cd-0eec-d708a3b44570.ref@aol.com>
2020-08-10 15:58 ` Clive Tovero
2020-08-09 20:49 Karl Fogel
2020-08-09 20:52 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfbb47cf-2185-b1d9-71d6-0ecb80735723@aol.com \
    --to=clive.tovero@aol.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).