From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Clive Tovero <clive.tovero@aol.com>, emacs-devel@gnu.org
Subject: Re: Okay to commit purely cosmetic (indendation) fixes?
Date: Mon, 10 Aug 2020 08:23:49 -0400 [thread overview]
Message-ID: <jwva6z21yjr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y2mm7owp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 10 Aug 2020 12:53:26 +0200")
>> Lars Ingebrigtsen: I don't understand why you wouldn't bundle
>> whitespace changes, rather than one at a time, as long as they were to
>> correct deviations from a coding standard.
> Whitespace changes make following code changes more difficult when
> digging into the history.
They're also a source of painful spurious conflicts for people
managing branches. So we prefer that whitespace changes are only
installed along with real changes that touch that same code, although we
definitely tolerate a few extra whitespace touch ups here and there.
Stefan
next prev parent reply other threads:[~2020-08-10 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com>
2020-08-09 22:40 ` Okay to commit purely cosmetic (indendation) fixes? Clive Tovero
2020-08-10 10:53 ` Lars Ingebrigtsen
2020-08-10 12:23 ` Stefan Monnier [this message]
2020-08-10 16:20 ` Karl Fogel
2020-08-10 14:04 ` Eli Zaretskii
2020-08-10 15:39 ` Clive Tovero
2020-08-10 15:51 ` Eli Zaretskii
2020-08-10 17:55 ` Clive Tovero
[not found] <e0dab5e9-5603-b2cd-0eec-d708a3b44570.ref@aol.com>
2020-08-10 15:58 ` Clive Tovero
2020-08-09 20:49 Karl Fogel
2020-08-09 20:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva6z21yjr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=clive.tovero@aol.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).